Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dynamic subscriptions in Argo CD source plugin #1272

Open
5 tasks
chrislwade opened this issue Sep 21, 2023 · 1 comment
Open
5 tasks

Allow dynamic subscriptions in Argo CD source plugin #1272

chrislwade opened this issue Sep 21, 2023 · 1 comment
Labels
enhancement New feature or request needs-triage Relates to issues that should be refined

Comments

@chrislwade
Copy link

Overview

Update Argo CD source plugin to dynamically subscribe to newly created Argo CD Applications without requiring a configuration change or plugin restart. This could be implemented via selectors and annotations or allowing name within the existing static configuration to be a regular expression.

Acceptance Criteria

  • PREFERRED: Add app selector based configuration for defaultSubscriptions.
  • ALTERNATIVELY: Update defaultSubscriptions.applications[*].name to be expressed as a regular expression.
  • Ensure newly created/deleted, matching, applications have subscriptions created and deleted dynamically without requiring a configuration reload.
  • Make sure documentation is up-to-date, create one if needed
  • Add test coverage for happy-path (unit or e2e test)

Reason

When using ApplicationSet or the app-of-apps pattern to dynamically create Applications within Argo CD itself, having to reconfigure and restart Botkube to enable notifications for newly created applications is not ideal.

@chrislwade chrislwade added the enhancement New feature or request label Sep 21, 2023
@pkosiec pkosiec added this to Botkube Sep 21, 2023
@pkosiec pkosiec added the needs-triage Relates to issues that should be refined label Sep 21, 2023
@pkosiec
Copy link
Collaborator

pkosiec commented Sep 27, 2023

Thank you Christopher for the issue. This relates to the issue #1240 as we also use app of apps approach.

Just to make sure it is archived, here's the full conversation:
obraz
obraz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-triage Relates to issues that should be refined
Projects
Status: No status
Development

No branches or pull requests

2 participants