Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template: specify priority class #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maiqueb
Copy link
Collaborator

@maiqueb maiqueb commented Dec 11, 2024

What this PR does / why we need it:
This PR specifies the deployment's priority class, thus assuring the component is not preempted for other workloads with lesses priority.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Specify the kubevirt-cluster-critical priorityClass for this deployment. It requires KubeVirt to be deployed.

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 11, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from maiqueb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@oshoval oshoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happen if someone tries to deploy it without kubevirt ?
(and the PC doesnt exists)
well he cant anyhow because it listens to VM / VMI i guess so it is non issue

@maiqueb
Copy link
Collaborator Author

maiqueb commented Dec 12, 2024

what happen if someone tries to deploy it without kubevirt ? (and the PC doesnt exists) well he cant anyhow because it listens to VM / VMI i guess so it is non issue

Yeah, that's kind of the point ... This is a project in the kubevirt org ...

I guess we should add to the docs a note indicating this must be used w/ kubevirt.

Let me check what happens though ...

@oshoval
Copy link
Collaborator

oshoval commented Dec 12, 2024

Please dont over invest on that, it also happens on KubeSecondaryDNS, and we concluded there it is fine
release note is more than enough imho

@maiqueb maiqueb requested a review from oshoval December 12, 2024 12:23
@oshoval
Copy link
Collaborator

oshoval commented Dec 12, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2024
@oshoval
Copy link
Collaborator

oshoval commented Dec 12, 2024

btw are you sure you want to use this pc ?
i remember that we used the system critical pc and the other one that k8s gives for the components (forgot the name),
we considered components that are mandatory for kubevirt to have higher prio than kubevirt
if it was a DS it was highest prio pc,
if it was a Deployment that could be on any node, it was the one below that, but higher than kubevirt
Petr was in the loop, in case i am wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants