-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
template: specify priority class #77
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happen if someone tries to deploy it without kubevirt ?
(and the PC doesnt exists)
well he cant anyhow because it listens to VM / VMI i guess so it is non issue
Yeah, that's kind of the point ... This is a project in the kubevirt org ... I guess we should add to the docs a note indicating this must be used w/ kubevirt. Let me check what happens though ... |
Please dont over invest on that, it also happens on KubeSecondaryDNS, and we concluded there it is fine |
/lgtm |
btw are you sure you want to use this pc ? |
What this PR does / why we need it:
This PR specifies the deployment's priority class, thus assuring the component is not preempted for other workloads with lesses priority.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: