From 71bde614defd9b37b9d1d56b5cc79e2c63becc8a Mon Sep 17 00:00:00 2001
From: Yaacov Zamir <yzamir@dhcp-2-158.tlv.redhat.com>
Date: Sun, 24 Mar 2019 18:48:27 +0200
Subject: [PATCH] Do not get template if not in edit mode.

---
 src/components/Details/Flavor/Flavor.js       |  10 +
 .../Details/Flavor/tests/Flavor.test.js       |   5 +
 .../tests/__snapshots__/Flavor.test.js.snap   |  58 ++++++
 .../VmDetails/fixtures/VmDetails.fixture.js   |  39 ++++
 .../Details/VmDetails/tests/VmDetails.test.js |   5 +
 .../__snapshots__/VmDetails.test.js.snap      | 177 ++++++++++++++++++
 6 files changed, 294 insertions(+)

diff --git a/src/components/Details/Flavor/Flavor.js b/src/components/Details/Flavor/Flavor.js
index 9ac681622..685405863 100644
--- a/src/components/Details/Flavor/Flavor.js
+++ b/src/components/Details/Flavor/Flavor.js
@@ -32,6 +32,16 @@ export class Flavor extends React.Component {
   };
 
   componentDidMount() {
+    // If not in edit mode, just init state and exit.
+    if (!this.props.editing) {
+      this.setState({
+        loadingTemplate: false,
+        template: null,
+      });
+
+      return;
+    }
+
     this.setState({
       loadingTemplate: true,
     });
diff --git a/src/components/Details/Flavor/tests/Flavor.test.js b/src/components/Details/Flavor/tests/Flavor.test.js
index 508364eb6..526e0e5d6 100644
--- a/src/components/Details/Flavor/tests/Flavor.test.js
+++ b/src/components/Details/Flavor/tests/Flavor.test.js
@@ -6,10 +6,15 @@ import { Flavor } from '..';
 import { default as FlavorFixture } from '../fixtures/Flavor.fixture';
 
 const testFlavor = () => <Flavor {...FlavorFixture[0].props} id="myflavor" />;
+const testFlavorEdit = () => <Flavor {...FlavorFixture[1].props} id="myflavor" />;
 
 describe('<Flavor />', () => {
   it('renders correctly', () => {
     const component = shallow(testFlavor());
     expect(component).toMatchSnapshot();
   });
+  it('renders correctly in edit mode', () => {
+    const component = shallow(testFlavorEdit());
+    expect(component).toMatchSnapshot();
+  });
 });
diff --git a/src/components/Details/Flavor/tests/__snapshots__/Flavor.test.js.snap b/src/components/Details/Flavor/tests/__snapshots__/Flavor.test.js.snap
index 1822379dd..a729270f7 100644
--- a/src/components/Details/Flavor/tests/__snapshots__/Flavor.test.js.snap
+++ b/src/components/Details/Flavor/tests/__snapshots__/Flavor.test.js.snap
@@ -45,3 +45,61 @@ exports[`<Flavor /> renders correctly 1`] = `
   </div>
 </InlineEdit>
 `;
+
+exports[`<Flavor /> renders correctly in edit mode 1`] = `
+<InlineEdit
+  LoadingComponent={[Function]}
+  editing={true}
+  fieldsValues={
+    Object {
+      "cpu": Object {
+        "value": "2",
+      },
+      "flavor": Object {
+        "value": "Custom",
+      },
+      "memory": Object {
+        "value": "2",
+      },
+    }
+  }
+  formFields={
+    Object {
+      "cpu": Object {
+        "id": "myflavor-flavor-cpu",
+        "isVisible": [Function],
+        "required": true,
+        "title": "CPU",
+        "type": "positive-number",
+      },
+      "flavor": Object {
+        "choices": Array [
+          "Custom",
+        ],
+        "id": "myflavor-flavor-dropdown",
+        "type": "dropdown",
+      },
+      "memory": Object {
+        "id": "myflavor-flavor-memory",
+        "isVisible": [Function],
+        "required": true,
+        "title": "Memory (GB)",
+        "type": "positive-number",
+      },
+    }
+  }
+  onFormChange={[Function]}
+  updating={true}
+>
+  <div
+    id="myflavor-flavor"
+  >
+    small
+  </div>
+  <div
+    id="myflavor-flavor-description"
+  >
+    2 CPU, 2G Memory
+  </div>
+</InlineEdit>
+`;
diff --git a/src/components/Details/VmDetails/fixtures/VmDetails.fixture.js b/src/components/Details/VmDetails/fixtures/VmDetails.fixture.js
index f2d08a4d1..021fd8d04 100644
--- a/src/components/Details/VmDetails/fixtures/VmDetails.fixture.js
+++ b/src/components/Details/VmDetails/fixtures/VmDetails.fixture.js
@@ -87,6 +87,35 @@ export const vmFixtures = {
       running: false,
     },
   },
+  vmWithDeletedTemplate: {
+    metadata: {
+      ...metadata,
+      labels: {
+        'flavor.template.cnv.io/small': 'true',
+        'os.template.cnv.io/fedora29': 'true',
+        [LABEL_USED_TEMPLATE_NAME]: 'deleted-template',
+        [LABEL_USED_TEMPLATE_NAMESPACE]: 'default',
+        'workload.template.cnv.io/generic': 'true',
+      },
+    },
+    spec: {
+      template: {
+        spec: {
+          domain: {
+            cpu: {
+              cores: 2,
+            },
+            resources: {
+              requests: {
+                memory: '2G',
+              },
+            },
+          },
+        },
+      },
+      running: false,
+    },
+  },
   customVm: {
     metadata: {
       ...metadata,
@@ -204,4 +233,14 @@ export default [
       overview: true,
     },
   },
+  {
+    component: VmDetails,
+    name: 'VM detail with deleted template',
+    props: {
+      vm: vmFixtures.vmWithDeletedTemplate,
+      k8sPatch,
+      k8sGet,
+      NodeLink: () => true,
+    },
+  },
 ];
diff --git a/src/components/Details/VmDetails/tests/VmDetails.test.js b/src/components/Details/VmDetails/tests/VmDetails.test.js
index 20a4eedd8..4aa95a2e7 100644
--- a/src/components/Details/VmDetails/tests/VmDetails.test.js
+++ b/src/components/Details/VmDetails/tests/VmDetails.test.js
@@ -60,6 +60,11 @@ describe('<VmDetails />', () => {
     const component = render(testVmDetails(vmFixtures.runningVm, { overview: true }));
     expect(component).toMatchSnapshot();
   });
+
+  it('renders deleted template correctly', async () => {
+    const component = render(testVmDetails(vmFixtures.vmWithDeletedTemplate));
+    expect(component).toMatchSnapshot();
+  });
 });
 
 describe('<VmDetails /> enzyme', () => {
diff --git a/src/components/Details/VmDetails/tests/__snapshots__/VmDetails.test.js.snap b/src/components/Details/VmDetails/tests/__snapshots__/VmDetails.test.js.snap
index 94144dc56..449dd336e 100644
--- a/src/components/Details/VmDetails/tests/__snapshots__/VmDetails.test.js.snap
+++ b/src/components/Details/VmDetails/tests/__snapshots__/VmDetails.test.js.snap
@@ -175,6 +175,183 @@ Array [
 ]
 `;
 
+exports[`<VmDetails /> enzyme renders deleted template correctly 1`] = `
+Array [
+  <h1
+    class="co-m-pane__heading"
+  >
+    Virtual Machine Overview
+    <div>
+      <button
+        class="btn btn-default"
+        type="button"
+      >
+        Edit
+      </button>
+    </div>
+  </h1>,
+  <div
+    class="kubevirt-vm-details__content"
+  >
+    <dl
+      class="kubevirt-vm-details__name-list"
+    >
+      <dt
+        class=""
+      >
+        Name
+      </dt>
+      <dd
+        class=""
+        id="my-namespace-my-vm-name"
+      >
+        my-vm
+      </dd>
+      <dt
+        class=""
+      >
+        Description
+      </dt>
+      <dd>
+        <div
+          class="kubevirt-vm-details__description"
+        >
+          <div
+            id="my-namespace-my-vm-description"
+          >
+            ---
+          </div>
+        </div>
+      </dd>
+    </dl>
+    <div
+      class="kubevirt-vm-details__details"
+    >
+      <dl
+        class="kubevirt-vm-details__details-list"
+      >
+        <dt>
+          Status
+        </dt>
+        <dd>
+          <div>
+            <span
+              aria-hidden="true"
+              class="kubevirt-vm-status__icon pficon pficon-off"
+            />
+            Off
+          </div>
+        </dd>
+        <dt>
+          Operating System
+        </dt>
+        <dd
+          id="my-namespace-my-vm-os"
+        >
+          fedora29
+        </dd>
+        <dt>
+          IP Addresses
+        </dt>
+        <dd
+          id="my-namespace-my-vm-ip-addresses"
+        >
+          ---
+        </dd>
+        <dt>
+          Workload Profile
+        </dt>
+        <dd
+          id="my-namespace-my-vm-workload-profile"
+        >
+          generic
+        </dd>
+        <dt>
+          Template
+        </dt>
+        <dd
+          id="my-namespace-my-vm-template"
+        >
+          default/deleted-template
+        </dd>
+      </dl>
+      <div
+        class="kubevirt-vm-details__other-details"
+      >
+        <dl
+          class="kubevirt-vm-details__details-list"
+        >
+          <dt>
+            FQDN
+          </dt>
+          <dd
+            id="my-namespace-my-vm-fqdn"
+          >
+            ---
+          </dd>
+          <dt>
+            Namespace
+          </dt>
+          <dd
+            id="my-namespace-my-vm-namespace"
+          >
+            ---
+          </dd>
+          <dt>
+            Pod
+          </dt>
+          <dd
+            id="my-namespace-my-vm-pod"
+          >
+            ---
+          </dd>
+          <dd>
+            ---
+          </dd>
+          <dt>
+            Boot Order
+          </dt>
+          <dd
+            id="my-namespace-my-vm-boot-order"
+          >
+            ---
+          </dd>
+        </dl>
+        <dl
+          class="kubevirt-vm-details__details-list"
+        >
+          <dt>
+            Node
+          </dt>
+          <dd
+            id="my-namespace-my-vm-node"
+          >
+            ---
+          </dd>
+          <dt>
+            Flavor
+          </dt>
+          <dd>
+            <div>
+              <div
+                id="my-namespace-my-vm-flavor"
+              >
+                small
+              </div>
+              <div
+                id="my-namespace-my-vm-flavor-description"
+              >
+                2 CPU, 2G Memory
+              </div>
+            </div>
+          </dd>
+        </dl>
+      </div>
+    </div>
+  </div>,
+]
+`;
+
 exports[`<VmDetails /> renders CPU and Memory settings for VM with custom flavor 1`] = `
 Array [
   <h1