Semi-colon shown at the bottom of the VMs List

[lizsurette]

We should remove the semi-colon at the bottom of the VMs List.

[mareklibra]

eagle-eyed Liz :-)

[jelkosz]

@mareklibra this has been targeted to 1.3 and it seems to be merged only to master. Reopening

[mareklibra]

The issue was closed automatically by github thanks to the Fixes: text in PR.
We should probably avoid this feature (otherwise nice, imho). Or do you know about better "procedure"?

It's responsibility of the PR author to backport the patch if needed. So the author should do this along pushing the master-PR. Within the PR review, we should be careful about the issue target as well and request separate PR addressing that.

Since this is generic topic, adding others:
FYI: @pcbailey @suomiy , @rawagner , @vojtechszocs

[jelkosz]

The issue was closed automatically by github thanks to the Fixes: text in PR.
We should probably avoid this feature (otherwise nice, imho). Or do you know about better "procedure"?

Other option is to do it similarly to manageiq where a separate issue is opened per branch. The patch author only contributes the patch to master and all of the patches are cherry-picked in a "bulk" by the stable branch maintainer solving the conflicts on the way. Honestly I find this approach too risky so just mentioning it in a hope that everyone will disagree :)

It's responsibility of the PR author to backport the patch if needed. So the author should do this along pushing the master-PR. Within the PR review, we should be careful about the issue target as well and request separate PR addressing that.

this is basically how oVirt does it. It is the responsibility of the patch author to make sure the patch will be backported to all branches and closes the bug only once the patch is successfully merged to the bottom-most branch. I prefer this option but maybe Im just biased doing this for years in oVirt :)

Since this is generic topic, adding others:
FYI: @pcbailey @suomiy , @rawagner , @vojtechszocs
@ohadlevy

[pcbailey]

It's responsibility of the PR author to backport the patch if needed. So the author should do this along pushing the master-PR. Within the PR review, we should be careful about the issue target as well and request separate PR addressing that.

this is basically how oVirt does it. It is the responsibility of the patch author to make sure the patch will be backported to all branches and closes the bug only once the patch is successfully merged to the bottom-most branch. I prefer this option but maybe Im just biased doing this for years in oVirt :)

Maybe it's my time on oVirt affecting my judgment as well, but I also agree with this approach. =)

[jelkosz]

okey, bacport merged: #70 closing issue

[mareklibra]

Fixed by #61 and later re-introduced by #83

[mareklibra]

I'll fix it again with other changes