From ca10af62874f116c2559d5c73d8ebea4959f10d5 Mon Sep 17 00:00:00 2001 From: Marek Libra Date: Thu, 8 Nov 2018 10:01:43 +0100 Subject: [PATCH 1/2] Fix: Remove extra semicolon Regression. Fixed by: https://github.com/kubevirt/web-ui/pull/61 Re-introduced by later merge of: https://github.com/kubevirt/web-ui/pull/83 --- frontend/public/kubevirt/components/vm.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/public/kubevirt/components/vm.jsx b/frontend/public/kubevirt/components/vm.jsx index bbade2d0124..847b2f05f94 100644 --- a/frontend/public/kubevirt/components/vm.jsx +++ b/frontend/public/kubevirt/components/vm.jsx @@ -379,7 +379,7 @@ export const VirtualMachinesPage = connect( ListComponent={VMList} createProps={this.createProps} rowFilters={filters} - />; + /> ; } }); From 4f63077155ba8df5a799a2f0d645f7661a4e2043 Mon Sep 17 00:00:00 2001 From: Marek Libra Date: Thu, 8 Nov 2018 10:24:20 +0100 Subject: [PATCH 2/2] Fix: VM Detail broken tabs By 31978462402ec4b52101d5a24c0384fd652b646a, the order of primary and secondary tabs is changed. The primary ones must be listed beofre others. --- frontend/public/kubevirt/components/vm.jsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frontend/public/kubevirt/components/vm.jsx b/frontend/public/kubevirt/components/vm.jsx index 847b2f05f94..9027198867c 100644 --- a/frontend/public/kubevirt/components/vm.jsx +++ b/frontend/public/kubevirt/components/vm.jsx @@ -253,12 +253,12 @@ const Details = ({obj: vm}) => { export const VirtualMachinesDetailsPage = props => { const pages = [navFactory.details(Details)]; - pages.push({ // TODO: might be moved based on review; or display conditionally if VM is running? + pages.push(navFactory.editYaml()); + pages.push({ href: 'consoles', name: 'Consoles', component: VmConsolesConnected }); - pages.push(navFactory.editYaml()); return (