Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #62

Merged
merged 3 commits into from
Sep 5, 2017
Merged

Fix typo #62

merged 3 commits into from
Sep 5, 2017

Conversation

krokofant
Copy link
Contributor

No description provided.

kuflash and others added 2 commits June 14, 2017 21:20
* Fix default value for options in build method #56
* Update version to 1.1.1
@kuflash
Copy link
Owner

kuflash commented Sep 4, 2017

@krokofant thank you, but can you create this PR from develop branch in your fork to develop branch in this repository?

@krokofant krokofant changed the base branch from master to develop September 4, 2017 22:30
@krokofant
Copy link
Contributor Author

krokofant commented Sep 4, 2017

I have no idea what I'm doing. 😅 Is this alright or did some commits get included that shouldn't have?

@Matzu89
Copy link
Contributor

Matzu89 commented Sep 4, 2017

It is a sharp fix, thats a fact.

You pushed it to the master branch, while pull requests are normally merged into the develop branch before a new release is published.

@kuflash kuflash merged commit 555e05c into kuflash:develop Sep 5, 2017
@kuflash kuflash mentioned this pull request Sep 29, 2017
kuflash added a commit that referenced this pull request Sep 29, 2017
Update version for publish PR #62 #64
kuflash added a commit that referenced this pull request Sep 29, 2017
* Fix typo in example code (#62)
* Removes parenthesis around replaced params (#64)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants