Add independent createRoutes method to support v4 react-router #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 1.1.5
…use and now support v4 react-router. Update peerDependencies and api.md.
|
@Joseph7451797 very good work! Can you change destination branch to |
@kuflash I already changed destination branch to |
|
@Joseph7451797 I apologize for the late reply. Can you create example for use react-router-4 with react-router-sitemap. Maybe only code examples in README.md. |
|
@kuflash Code example of v4 |
|
@Joseph7451797 cool, that is all. Thank you! |
Merged
kuflash
added a commit
that referenced
this pull request
Jan 30, 2019
* Add support React Router v4 (#82) * Release 1.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borrow
createRoutesfunction from v3 react-router code base and make it as a internal function. This fixes the missingcreateRoutesmethod issue which caused by complete rewrite of v4 react-router.