Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KLoader has issue where progress can exceed 100 #135

Closed
darrenjennings opened this issue Feb 11, 2021 · 1 comment
Closed

KLoader has issue where progress can exceed 100 #135

darrenjennings opened this issue Feb 11, 2021 · 1 comment
Assignees
@tomaszwylezek

Comments

@darrenjennings
Copy link
Contributor

I noticed that the KLoader is using a copied version of an old component. We moved the Full screen loader to a kongponent (which resolves the >100 progress bug):

https://github.com/Kong/kongponents/blob/master/packages/KSkeleton/FullScreenKongSkeleton.vue#L54
https://github.com/kumahq/kuma-gui/blob/master/src/components/KLoader.vue#L43

Possible solution is that the KLoader can receive an asset name so that the assets can be customized so you could pass ../assets/images/kuma-loader-v1.gif?external to KSkeleton, and then have kuma-gui use the kskeleton kongponent.
@bloqhead bloqhead self-assigned this Feb 12, 2021
@bloqhead bloqhead added the bug label Feb 12, 2021
@tomaszwylezek tomaszwylezek mentioned this issue Jul 29, 2021
Merged
@tomaszwylezek
Copy link
Contributor

It was fixed in #187 and merged into kuma in kumahq/kuma#2481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomaszwylezek tomaszwylezek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bloqhead @darrenjennings @tomaszwylezek