Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kuma-prometheus-sd doesn't work with MADs v1 #1886

Closed
lobkovilya opened this issue Apr 27, 2021 · 3 comments · Fixed by #1896
Closed

kuma-prometheus-sd doesn't work with MADs v1 #1886

lobkovilya opened this issue Apr 27, 2021 · 3 comments · Fixed by #1896
Assignees
@austince

Comments

@lobkovilya
Copy link
Contributor

Summary

Apparently conversion from *observability_v1.MonitoringAssignment to []*targetgroup.Group happens with errors.
kuma-prometheus-sd receives 4 targets from Kuma Control Plane, but kuma.file_sd.json contains only 1 target.

Steps To Reproduce

  1. Run kuma-prometheus-sd with v1
@lobkovilya lobkovilya mentioned this issue Apr 27, 2021
Merged
@austince
Copy link
Contributor

Thanks for reporting, will look into.

@austince austince self-assigned this Apr 27, 2021
@austince
Copy link
Contributor

Were there errors in the log, or was the lack of targets the only indication something went wrong? Do you have the list of the 4 present DPs and produced kuma.file_sd.json by any chance?

I think there might be an issue with the handler using the targetgroup.Group.Source property as a unique identifier, and am wondering if this is related or a separate issue.

@austince austince mentioned this issue Apr 27, 2021
Merged
1 task
@austince
Copy link
Contributor

austince commented Apr 27, 2021 •
edited
Loading

Draft PR #1896 might address this, if it is the cause. Would you be able to try it out?

@austince austince changed the title MADs v1 client doesn't work kuma-prometheus-sd doesn't work with MADs v1 Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@austince austince

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(prometheus-sd) namespace source names for v1 API kumahq/kuma
2 participants
@austince @lobkovilya