Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated envoy.config.cluster.v3.Cluster.http2_protocol_options #2113

Closed
jpeach opened this issue Jun 7, 2021 · 5 comments · Fixed by #4528
Closed

Replace deprecated envoy.config.cluster.v3.Cluster.http2_protocol_options #2113

jpeach opened this issue Jun 7, 2021 · 5 comments · Fixed by #4528
Labels
area/envoy kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it triage/stale Inactive for some time. It will be triaged again

Comments

@jpeach
Copy link
Contributor

jpeach commented Jun 7, 2021

Summary

2021-06-07T16:10:07.388+1000	INFO	kuma-dp.run.envoy	fetched Envoy version	
{"version": {"Build":"98c1c9e9a40804b93b074badad1cdf284b47d58b/1.18.3/clean-getenvoy-b76c773-envoy/RELEASE/BoringSSL","Version":"1.18.3"}}

[2021-06-07 16:10:07.746][271353][warning][misc] [external/envoy/source/common/protobuf/message_validator_impl.cc:21] 
Deprecated field: type envoy.config.cluster.v3.Cluster Using deprecated option 'envoy.config.cluster.v3.Cluster.http2_protocol_options' from file cluster.proto. 
This configuration will be removed from Envoy soon. 
Please see https://www.envoyproxy.io/docs/envoy/latest/version_history/version_history for details. 
If continued use of this field is absolutely necessary, see https://www.envoyproxy.io/docs/envoy/latest/configuration/operations/runtime#using-runtime-overrides-for-deprecated-features for how to apply a temporary and highly discouraged override.

Additional Details & Logs

The replacement for this is the HttpProtocolOptions API since Envoy 1.17.0 (release notes).
@jpeach jpeach added the envoy label Jun 7, 2021
@jpeach jpeach mentioned this issue Jun 10, 2021
Merged
5 tasks
@jakubdyszkiewicz
Copy link
Contributor

done

@jpeach
Copy link
Contributor Author

jpeach commented Jul 4, 2021

This doesn't appear to be fully removed in latest master:

[2021-07-05 07:38:19.939][466213][warning][misc] [external/envoy/source/common/protobuf/message_validator_impl.cc:21] Deprecated field: type envoy.config.cluster.v3.Cluster Using deprecated option 'envoy.config.cluster.v3.Cluster.http2_protocol_options' from file cluster.proto. This configuration will be removed from Envoy soon. Please see https://www.envoyproxy.io/docs/envoy/latest/version_history/version_history for details. If continued use of this field is absolutely necessary, see https://www.envoyproxy.io/docs/envoy/latest/configuration/operations/runtime#using-runtime-overrides-for-deprecated-features for how to apply a temporary and highly discouraged override.

@jpeach jpeach reopened this Jul 4, 2021
@lahabana lahabana added area/envoy and removed envoy labels Nov 22, 2021
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Dec 26, 2021
@lahabana lahabana added kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/stale Inactive for some time. It will be triaged again labels Apr 26, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 27, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label May 30, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jun 30, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@michaelbeaumont michaelbeaumont mentioned this issue Jun 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/envoy kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it triage/stale Inactive for some time. It will be triaged again
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove deprecated Cluster.Http2ProtocolOptions michaelbeaumont/kuma
3 participants
@jpeach @lahabana @jakubdyszkiewicz