Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional debug logging for api-server #2400

Closed
bdecoste opened this issue Jul 20, 2021 · 3 comments
Closed

Add additional debug logging for api-server #2400

bdecoste opened this issue Jul 20, 2021 · 3 comments
Labels
area/kuma-cp area/observability triage/rotten closed due to lack of information for too long, rejected feature...

Comments

@bdecoste
Copy link
Contributor

Summary

Needed to debug the product and version returned to kumactl generate dataplane-token ...
@jpeach
Copy link
Contributor

jpeach commented Jul 21, 2021

The error message WARNING: You are using kumactl version XXX, but the server returned version: YYY comes from a server version pre-flight check in kumactl. This does a GET on '/' for the API server that it is configured for, and that GET request returns hostname, tagline(?) and version fields.

So in this case, any kumactl command ought to emit that warning as long as it reaches the same in API server instance. This was added in #736.

I don't see any code in the token issuance path that knows the Kuma version of the client.

@parkanzky parkanzky mentioned this issue Jul 27, 2021
Merged
6 tasks
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Dec 25, 2021
@lahabana lahabana added triage/rotten closed due to lack of information for too long, rejected feature... and removed triage/stale Inactive for some time. It will be triaged again labels May 23, 2022
@github-actions
Copy link
Contributor

Automatically closing the issue due to having one of the "closed state label".

@lahabana lahabana mentioned this issue May 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/kuma-cp area/observability triage/rotten closed due to lack of information for too long, rejected feature...
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpeach @bdecoste @lahabana