xDS generators should require resource names

[jpeach]

Summary

The xDS generators do not require xDS resources to be named, and there's no checking for that until you get to the consistency snapshot.

Code that looks like it should do nothing will generate anonymous resources, e.g:

b := envoy_routes.NewRouteConfigurationBuilder(envoy.APIV3)
r, err := b.Build()

// r doesn't have a resource name here ...

There are cases where its OK to generate xDS resources that don't have names, but maybe it's more robust to always require them.

Discuss :)

[github-actions]

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

[jakubdyszkiewicz]

Triage
Option 1: b.Build(name)
Option 2: validate that the name is set in .Build(), but this is a runtime error instead of build error

[github-actions]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

[github-actions]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

[github-actions]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

[github-actions]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

[github-actions]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

[jakubdyszkiewicz]

Seems like all builders in pkg/xds/envoy requires names now. Closing