Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy application metrics through envoy #3457

Closed
lahabana opened this issue Dec 9, 2021 · 4 comments · Fixed by #4286
Closed

Proxy application metrics through envoy #3457

lahabana opened this issue Dec 9, 2021 · 4 comments · Fixed by #4286
Assignees
Labels
area/kuma-dp kind/design Design doc or related kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

lahabana commented Dec 9, 2021

Description

Currently the application metrics are exposed as a regular service.
This is tricky if you want prometheus metrics scrape to not use mTLS.
See doc: https://kuma.io/docs/1.4.0/policies/traffic-metrics/#expose-metrics-from-applications

What could be done is for envoy to proxy metrics from the application as a service similar to the prometheus one.
This way we could easily use kuma-sd to also expose application metrics and not risk customers to accidentally expose more than necessary.

Once this is done it will probably make sense to disable mTLS on the listener exposing metrics by default (most of the time prometheus scrape is in plaintext).

It's currently unclear how this should be setup and requires some designing.

@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature kind/design Design doc or related labels Dec 9, 2021
@lahabana
Copy link
Contributor Author

lahabana commented Dec 9, 2021

This is tricky to setup on a per service base as currently TrafficMetrics are only part of the Mesh configuration.

@lahabana lahabana added triage/accepted The issue was reviewed and is complete enough to start working on it area/kuma-dp and removed triage/pending This issue will be looked at on the next triage meeting labels Dec 13, 2021
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jan 13, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Jan 13, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 13, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kuma-dp kind/design Design doc or related kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants