Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API to retrieve the full XDS config for an Dataplane #3488

Closed
lahabana opened this issue Dec 13, 2021 · 4 comments · Fixed by #3768
Closed

API to retrieve the full XDS config for an Dataplane #3488

lahabana opened this issue Dec 13, 2021 · 4 comments · Fixed by #3768
Assignees
Labels
area/api area/observability kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

Description

This is useful for debugging issues. It should be a rest endpoint for each DP that outputs the generated XDS configuration.

This is complementary to #3460 to make it easier for users to understand their proxy configuration.

@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature area/api area/observability labels Dec 13, 2021
@lahabana
Copy link
Contributor Author

There's already some ways to access the admin api with the support of k8s Jobs (which calls /quitquitquit admin endpoint).
This can likely be built on top of this.

@lahabana lahabana added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Dec 13, 2021
@jpeach
Copy link
Contributor

jpeach commented Dec 13, 2021

It should be a rest endpoint for each DP that outputs the generated XDS configuration.

Does this need to go to the DP? The CP has the configuration cached already, so maybe we can fish that out.

@lahabana
Copy link
Contributor Author

Doesn't the dp potentially has rejected config errors that we wouldn't get on the CP?

@jpeach
Copy link
Contributor

jpeach commented Dec 14, 2021

Doesn't the dp potentially has rejected config errors that we wouldn't get on the CP?

If Envoy NACKed a snapshot, then the CP would get the NACK and know about it. Might be hard to fish this out of the xDS server, but Envoy doesn't know anything that the CP doesn't already know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api area/observability kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants