Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

policy-gen: targetRef should not be "omitempty" #5548

Closed
lobkovilya opened this issue Dec 22, 2022 · 1 comment · Fixed by #5593
Closed

policy-gen: targetRef should not be "omitempty" #5548

lobkovilya opened this issue Dec 22, 2022 · 1 comment · Fixed by #5593
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lobkovilya
Copy link
Contributor

Description

The initial assumption was to have a syntactic sugar for TargetRef. That's why the field was marked as omitempty. Since it's not the case anymore, we should remove omitempty for all TargetRefs and update the bootstrap policy generator.
@lobkovilya lobkovilya added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Dec 22, 2022
@lobkovilya lobkovilya mentioned this issue Dec 22, 2022
Merged
12 tasks
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Jan 3, 2023
@AyushSenapati
Copy link
Contributor

Hi @lobkovilya and @jakubdyszkiewicz, can I work on this issue?
I asked here to make sure no one else has already picked this.

@AyushSenapati AyushSenapati mentioned this issue Jan 7, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make targetRef required AyushSenapati/kuma
3 participants
@jakubdyszkiewicz @lobkovilya @AyushSenapati