Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep helm go dependency in sync with helm CLI version #6165

Closed
michaelbeaumont opened this issue Mar 1, 2023 · 7 comments
Closed

Keep helm go dependency in sync with helm CLI version #6165

michaelbeaumont opened this issue Mar 1, 2023 · 7 comments
Labels
area/ci-cd kind/improvement Improvement on an existing feature triage/rotten closed due to lack of information for too long, rejected feature...

Comments

@michaelbeaumont
Copy link
Contributor

Description

We use Helm in kumactl to render files and we also use helm to lint files during CI. These versions should be in sync. There can sometimes be changes to what's supported in templates between versions so the latter version must be the minimum Helm version our charts support!

@michaelbeaumont michaelbeaumont added area/ci-cd triage/pending This issue will be looked at on the next triage meeting kind/improvement Improvement on an existing feature labels Mar 1, 2023
@lahabana
Copy link
Contributor

lahabana commented Mar 1, 2023

Should we just do something like https://github.com/kumahq/kuma/blob/master/mk/dependencies/go-deps.sh#L11 ?

Also I was thinking that potentially this version should be actually saved to the file as the lock file doesn't include go.mod

@michaelbeaumont
Copy link
Contributor Author

Yes, we definitely should. But then we need to downgrade Helm in kumactl, which should be fine.

@lahabana
Copy link
Contributor

lahabana commented Mar 1, 2023

Ho how come?

@michaelbeaumont
Copy link
Contributor Author

We use helm CLI to lint etc v3.8.2 because it's the minimum supported version of our charts. If these versions should be the same we'd need to downgrade go.mod. Or increase the minimum chart version but that seems unnecessary. Or just bump the CLI to v3.11 and hope we don't accidentally introduce a breaking change

@lahabana
Copy link
Contributor

lahabana commented Mar 1, 2023

Ha ok. Where do we specify the minimum version of helm?

@michaelbeaumont
Copy link
Contributor Author

We only do so implicitly by using helm lint with some version of Helm.

@jakubdyszkiewicz
Copy link
Contributor

Triage: It's not a bug. It's a feature. We want to check the chart against the oldest supported helm version

@jakubdyszkiewicz jakubdyszkiewicz closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2023
@jakubdyszkiewicz jakubdyszkiewicz added triage/rotten closed due to lack of information for too long, rejected feature... and removed triage/pending This issue will be looked at on the next triage meeting labels Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci-cd kind/improvement Improvement on an existing feature triage/rotten closed due to lack of information for too long, rejected feature...
Projects
None yet
Development

No branches or pull requests

3 participants