GNOME decorations hover should not use a gradient

[codic12]

The latest Adwaita version does not use a gradient when you hover over a button.

[kupiqu]

I heard about that, it seems this #21 does not apply anymore :(

I think there is some screenshot in some other issue, I'll try to find it

[kupiqu]

Oh, it's actually in #65

[codic12]

Ah ok ;)

[codic12]

Yup

Adwaita was updated for a more flat look :D

[kupiqu]

I guess it makes sense to change it if Gnome/Adwaita style users prefer it this way. Would you like to give it a try? It shouldn't be too difficult to change it

[codic12]

Sure! Where would I find the relevant files?

[kupiqu]

It's all in drawIconGnome function in breezebutton.cpp

[codic12]

Hm, I don't know C++. I'll take a look and see what I can do though

[kupiqu]

Hm, I don't know C++. I'll take a look and see what I can do though

I don't think you need much C++ knowledge for this purpose, give it a try :-)

[codic12]

I'm assuming you can just remove all the gradient references?
And then paint the standard color object instead of a gradient object?

[kupiqu]

Yes, just that. I recommend that you make changes one by one and check it on the fly.

And then you can consider whether buttons should be surrounded by circles or squares according to Adwaita...

[kupiqu]

Also, wondering whether we should keep previous Gnome style for those who like it, hmm, even though under a different name...

EDIT: but don't worry about it... it won't be difficult to have it back if someone requests it

[codic12]

Why not call this one adwaita and the old one 'old adwaita'?

Oh, ok

[kupiqu]

Why not call this one adwaita and the old one 'old adwaita'?

Oh, ok

Sure, I am all for it, didn't want to give you too much trouble ;-)

[codic12]

:P
I have a school assignment to do;I'll give it a shot after!

[kupiqu]

Sure, no hurries

[codic12]

got sidetracked. I cannot figure it out :(

[kupiqu]

Ok, no problem

[kupiqu]

My aim is that SBE is maintained by the community. This shouldn't be hard to fix. I hope someone in the community cares about SBE and submits a pull request about it... I could help if somebody wants to try but is lost where to start.