diff --git a/pkg/fleet-manager/fleet_plugin_metric.go b/pkg/fleet-manager/fleet_plugin_metric.go index 812d838a9..99a7db4c3 100644 --- a/pkg/fleet-manager/fleet_plugin_metric.go +++ b/pkg/fleet-manager/fleet_plugin_metric.go @@ -207,10 +207,10 @@ func (f *FleetManager) syncObjStoreSecret(ctx context.Context, fleetCluster *Fle }, }, metav1.CreateOptions{}) if err != nil { - return nil + return err } } else if err != nil { - return nil + return err } s, err := fleetCluster.Client.KubeClient().CoreV1().Secrets(secret.Namespace).Get(ctx, secret.Name, metav1.GetOptions{}) diff --git a/pkg/plugin/istio/install.go b/pkg/plugin/istio/install.go index 9d4c8cc83..012b12028 100644 --- a/pkg/plugin/istio/install.go +++ b/pkg/plugin/istio/install.go @@ -424,7 +424,7 @@ func (p *IstioPlugin) installRemotes(remotePilotAddress string) error { } if err := p.createIstioRemoteSecret(currentRemote); err != nil { - return nil + return err } if err := p.createRemoteIstioOperator(currentRemote, remotePilotAddress); err != nil { diff --git a/pkg/plugin/prometheus/plugin.go b/pkg/plugin/prometheus/plugin.go index 5bbd0ca55..9cf413170 100644 --- a/pkg/plugin/prometheus/plugin.go +++ b/pkg/plugin/prometheus/plugin.go @@ -196,7 +196,7 @@ func (p *Plugin) runInstall() error { func (p *Plugin) exposePrometheus() error { s, err := p.KubeClient().CoreV1().Services(monitoringNamespace).Get(context.TODO(), promSvcName, metav1.GetOptions{}) if err != nil { - return nil + return err } // 2. create elb service for prometheus