Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: upgrade to flame 1.9.1 #7

Merged
merged 16 commits into from
Sep 27, 2023
Merged

feat!: upgrade to flame 1.9.1 #7

merged 16 commits into from
Sep 27, 2023

Conversation

marcossevilla
Copy link
Contributor

  • Upgrades to flame version 1.8.2.
  • Refactors code for the new flame version and applies some standards from effective Dart.

@kurtome
Copy link
Owner

kurtome commented Sep 15, 2023

Thanks for the PR! looks great on a quick glance I'll follow up and merge as soon as I can

kurtome
kurtome reviewed Sep 16, 2023
View reviewed changes
packages/leap/lib/src/input.dart Outdated Show resolved Hide resolved
packages/leap/lib/src/input.dart Outdated Show resolved Hide resolved
packages/leap/lib/src/input.dart Outdated Show resolved Hide resolved
examples/standard_platformer/lib/player.dart Outdated Show resolved Hide resolved
examples/standard_platformer/lib/player.dart Outdated Show resolved Hide resolved
examples/standard_platformer/lib/player.dart Show resolved Hide resolved
examples/standard_platformer/lib/main.dart Show resolved Hide resolved
@marcossevilla marcossevilla changed the title feat!: upgrade to flame 1.8.2 feat!: upgrade to flame 1.9.1 Sep 25, 2023
@marcossevilla
Copy link
Contributor Author

hey @kurtome! just applied your feedback to the PR, let me know if it looks good to you

kurtome
kurtome approved these changes Sep 25, 2023
View reviewed changes
Copy link
Owner

@kurtome kurtome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, there are a few small things I want to refactor to clean-up how the world fields are instantiated and make sure there is only one world field, but I can make those changes after merging

examples/standard_platformer/lib/main.dart Outdated Show resolved Hide resolved
examples/standard_platformer/lib/main.dart Outdated Show resolved Hide resolved
packages/leap/lib/src/leap_world.dart Show resolved Hide resolved
packages/leap/lib/src/leap_game.dart Outdated Show resolved Hide resolved
@marcossevilla
Copy link
Contributor Author

@kurtome I'll apply the changes in a bit so we can merge all of this together 👍

@marcossevilla
Copy link
Contributor Author

@kurtome changes are up!

kurtome
kurtome requested changes Sep 25, 2023
View reviewed changes
Copy link
Owner

@kurtome kurtome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sample game is broken now, please run the game to validate your changes :)

There is an additional bug introduced in the latest changes where the player cannot jump

packages/leap/lib/src/leap_game.dart Outdated Show resolved Hide resolved
packages/leap/lib/src/leap_game.dart Outdated Show resolved Hide resolved
@marcossevilla
Copy link
Contributor Author

@kurtome I think it should be fixed now

kurtome
kurtome requested changes Sep 26, 2023
View reviewed changes
packages/leap/lib/src/leap_game.dart Outdated Show resolved Hide resolved
packages/leap/lib/src/leap_map.dart Outdated Show resolved Hide resolved
packages/leap/lib/src/leap_map.dart Outdated Show resolved Hide resolved
kurtome
kurtome approved these changes Sep 27, 2023
View reviewed changes
packages/leap/lib/src/leap_game.dart Show resolved Hide resolved
packages/leap/lib/src/leap_map.dart Show resolved Hide resolved
@kurtome kurtome merged commit 7b59cdc into kurtome:main Sep 27, 2023
4 checks passed
@kurtome
Copy link
Owner

kurtome commented Sep 27, 2023

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtome kurtome kurtome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcossevilla @kurtome @erickzanardo