-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we start with a more release based workflow. #86
Comments
yes I agree, this needs to go from a proof of concept to something people can rely on. After factoring out the chip file generator we should make a version 1 containing nothing but Kvasir::Register including the seams since that is the only thing I think is ready to freeze at this point. The question is if we want to put register in its own repo too. Register only depends on the chip files and brigand. The HAL of each peripheral as well as Kvasir::Io will depend on register but nothing above that. Our USB stack for example is entirely hardware agnostic above the HAL so there may be a legitimate argument at some point to put register somewhere else. |
we already use a modified gitflow |
I'm not completely agreeing with this. First of all, I don't think the forking is good final solution. For instance if two people want to implement atomic for all of the register abstraction library they should make a feature branch so they can cooperate. Another advantage of it is that you can see features in your gitflow. Leaving the registerfiles in repo also doesn't seem like a good idea because you break the versioning. The good thing about git is that it's really easy to see what's changed in source. The registerfiles are like binaries, they bloat your diffs. You are right tough on the easyness thing. We should preserve the easy way to use kvasir. But maybe you could archive that with one bootstrap script or something. It's also possible to host a "compiled" kvasir (with the registerfiles) somewhere as a zip. That zip is made every commit. This will keep the git clean and pure. addition: with registerfiles I mean the cpp files with the chip information... |
answer:
i never said final solution. But first we should get Kvasir full working (as atomicoperations etc)
If two people must cooporate, they can so this. i never said never. But now there are not many maintainer and everyone is more testing new stuff.
answer:
Merging would be than manually.
manually = not breaking versioning |
I think decomposing into sub libraries may make initial "try it out" type use cases a bit harder but it makes it easier for people to contribute. If we structure the lib so that different code is in different libs it is less intellectual overhead to get up and running with one of the libs. Plus its easier to express code ownership in terms of repos and its easier to track module specific issues. |
It also allows for versioning the thing separately which means the stable/unstable tag is also separated... |
as soon as we have more than on lib there is no reason to have the "Chip" files in the same repo as other stuff. |
If we want to make kvasir usable for production code we should be more save. With more safe I mean using a git policy that allows us to indicate when a version is stable and ready for use.
We could implement this by using git flow. Als we should do code reviews before any master merge. Main work should be done off the master branch.
I think we have to discuss this and write a git and test plan for this repo and the whole kvasir idea. What do you think?
The text was updated successfully, but these errors were encountered: