Unable to delete certain Text icons

[DarthGandalf]

Reported by OmegaPhil on 19 Aug 2010 20:19:33 UTC
See Settings -> Configure KVIrc... -> IRC -> Tools -> Text icons.

When you select a row here, you can use the Delete button to remove the row. In my case I only want a few strings to be replaced with icons, so I have deleted most entries. All 'word' entries have deleted fine (e.g. 'rose').

However, when I try to delete ':*' or ':|' and Apply or OK the changes, they reappear in the table. I haven't attempted to delete all entries so others may also be affected.

KVIrc details (ambossarm's Ubuntu Lucid build):

KVIrc 4.0.2 svn-402 'Insomnia' 20100627 - build 2010-08-02 17:44:33 UTC - Linux (2.6.32-24-server)

uname -a:

Linux 2.6.32-24-server #39-Ubuntu SMP Wed Jul 28 06:21:40 UTC 2010 x86_64 GNU/Linux

OS: Ubuntu Server 10.04

---

Migrated from: https://svn.kvirc.de/kvirc/ticket/911

[DarthGandalf]

Comment by anonymous on 19 Aug 2010 20:20:53
Confirmed with ambossarm in the #kvirc channel that at least ':/' also fails in the way described for him.

[DarthGandalf]

Modified by HelLViS69 on 21 Aug 2010 13:18:52
Version: none → 4.0.2 Insomnia

[DarthGandalf]

Comment by ctrlaltca on 21 Aug 2010 18:06:03
An internal "default associations" list exists in kvirc, and when saving the "text icons" options, kvirc ensures that this minimum amount of text/icon associations exists. This is the complete list:

static KviTextIconAssocEntry default_associations[]=
{
    { ":)"    , KVI_SMALLICON_SMILE       },
    { ":*"    , KVI_SMALLICON_KISS        },
    { ":D"    , KVI_SMALLICON_BIGGRIN     },
    { ":("    , KVI_SMALLICON_UGLY        },
    { ":/"    , KVI_SMALLICON_ANGRY       },
    { ":O"    , KVI_SMALLICON_SURPRISED2  },
    { ":P"    , KVI_SMALLICON_TONGUE      },
    { ";)"    , KVI_SMALLICON_EYE         },
    { ":°)"   , KVI_SMALLICON_TEARSMILE   },
    { ":°"    , KVI_SMALLICON_CRY         },
    { ":S"    , KVI_SMALLICON_AFRAID      },
    { ":|"    , KVI_SMALLICON_DEMORALIZED },
    { ":P°"   , KVI_SMALLICON_SLURP       },

I think this has been implemented first as a newbie-saving feature, but in effect it's questionable.

[DarthGandalf]

Comment by ctrlaltca on 21 Aug 2010 18:31:47
Removed the forced restore of "default associations" and added a "restore" button in text icons options. Revision r4922

---

Resolution: none → fixed
Status: new → closed

[DarthGandalf]

Comment by OmegaPhil on 21 Aug 2010 18:39:40
Thanks :)

[DarthGandalf]

Comment by OmegaPhil on 22 Aug 2010 11:39:28
Hmm, I have successfully tested this, however I have found a related problem (please say if I should make a new ticket):

I have tried to change the definition of the :p smiley from ':P' to ':p'. The settings accept the change, however when you use it in chat, ':p' is still a plain string and ':P' remains replaced with the icon.

Therefore, it seems changing the strings on at least some icons are not honoured.

---

Resolution: fixed → none
Status: closed → reopened

[DarthGandalf]

Comment by ctrlaltca on 22 Aug 2010 22:13:31
Some more fixes in r4925; the :p/:P mismatch is due to 2 facts:

1. some smileys are hardcoded (:P is one of them), but they should not be rendered if the associated icon doesn't exists;
2. currently matching is case insensitive, so :P will use the icon you defined for :p.
   This needs some more fixing..

---

Owner: pragmaware → ctrlaltca
Status: reopened → new

[DarthGandalf]

Comment by ctrlaltca on 25 Aug 2010 17:25:24
Added proper matching for lowercase versions of the hardcoded emoticons in r4934.
So, :p will work now.

---

Resolution: none → fixed
Status: new → closed

[DarthGandalf]

Modified by OmegaPhil on 29 Aug 2010 10:14:24