Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen for octave change? #5

Open
leifriksheim opened this issue Apr 25, 2018 · 1 comment
Open

Listen for octave change? #5

leifriksheim opened this issue Apr 25, 2018 · 1 comment

Comments

@leifriksheim
Copy link

Is there a way to listen for octave changes? I see that the keyboard.down listener only fires on notes – not octave change. I have a dynamic keyboard that needs to know when the octave is changing to render the correct active piano keys. For know is use the keyboard.get('octave') for every keyboard.down event, but it doesn't feel like the best solution.

@WheelyWonka
Copy link

I made a fork with that feature: https://github.com/WheelyWonka/AudioKeys for those who are looking for that one in 2021 😅

I could emit a PR if @kylestetz is interested.

this.keyboard.octaveChanged(octave => console.log('octaveChanged!', octave));
this.keyboard.velocityChanged(velocity => console.log('velocityChanged!', velocity));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants