Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Channel field to Manifest.Spec instead of the Channel label #1477

Closed
5 tasks
Tracked by #776
nesmabadr opened this issue Apr 17, 2024 · 3 comments
Closed
5 tasks
Tracked by #776

Add Channel field to Manifest.Spec instead of the Channel label #1477

nesmabadr opened this issue Apr 17, 2024 · 3 comments
Labels
API Denotes that an issue is tied to the potential change of the API kind/feature Categorizes issue or PR as related to a new feature.

Comments

@nesmabadr
Copy link
Contributor

nesmabadr commented Apr 17, 2024

Description

In the Manifest, we have the channel defined as a label operator.kyma-project.io/channel. We need to stop depending on this label and introduce a Channel field in the Manifest.Spec instead.

Reasons

No response

Acceptance Criteria

  • Introduce an optional Channel field to the v1beta2.Manifest spec
  • Prioritize using the spec field over the label
  • Remove adding the channel label from the manifest
  • Create an issue to have the Channel field mandatory in the next API version.
  • Make sure backwards compatibility is handled and tested.

Feature Testing

No response

Testing approach

No response

Attachments

No response

@nesmabadr nesmabadr added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 17, 2024
@jeremyharisch jeremyharisch added the API Denotes that an issue is tied to the potential change of the API label May 22, 2024
@nesmabadr nesmabadr self-assigned this May 22, 2024
@nesmabadr
Copy link
Contributor Author

Blocked by #1456 . Currently we don't reference the channel label anywhere except in the test utils, so when we introduce the change to avoid ssa unless there is a change in version or channel, we can process with this issue.

@nesmabadr nesmabadr removed their assignment May 27, 2024
@c-pius
Copy link
Contributor

c-pius commented Sep 6, 2024

In #1681 it has been decided that ModuleTemplates will be tied to versions. An assignment of modules to channels will happen via a separate CR, but eventually, we will always install a version of a module. Version is already part of the manifest. We need to evaluate if we even need channel info as part of the Manifest at all, or if we can completely rely on the version.

Blocked by #1456 . Currently we don't reference the channel label anywhere except in the test utils, so when we introduce the change to avoid ssa unless there is a change in version or channel, we can process with this issue.

Also seen that we only us this label in a test. Are we even relying on it somewhere?

@c-pius
Copy link
Contributor

c-pius commented Sep 9, 2024

Closing for the reasons mentioned above. Deprecation of the label should be handled in: #1839

@c-pius c-pius closed this as completed Sep 9, 2024
@c-pius c-pius closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Denotes that an issue is tied to the potential change of the API kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants