Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next NamePlate value is loaded at end of line #11

Open
Chip-Chup opened this issue Jun 22, 2022 · 4 comments
Open

Next NamePlate value is loaded at end of line #11

Chip-Chup opened this issue Jun 22, 2022 · 4 comments

Comments

@Chip-Chup
Copy link

Thanks for making this plugin. I did notice that when the end of line is reached, and the next line is loaded, the name in the nameplate is updated without waiting for a call to finish_line(). I fixed this myself by adding in a 'nextName' to YarnDisplay functioning similarly to 'nextLine', but I imagine other developers will be looking for a solution to that as well.

@kyperbelt
Copy link
Owner

Feel free to make a pull request with your changes.

@NeoWordire
Copy link

Ah I had this issue and devised a similar fix before seeing this.
Made a minimal pull request above.

@Baconinvader
Copy link

Also ran into this issue, @NeoWordire 's fix seems to work pretty well, is there a reason it isn't merged?

@NeoWordire
Copy link

I have no updates on my pull request as i just fired it into void. But I did run into one related issue worth note-ing that could also require a fix/new issue. The line_emiited signal is emitted on parse not on text update so if you hook into that symbol it also proceeds the display text by one line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants