-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next NamePlate value is loaded at end of line #11
Comments
Feel free to make a pull request with your changes. |
Ah I had this issue and devised a similar fix before seeing this. |
Also ran into this issue, @NeoWordire 's fix seems to work pretty well, is there a reason it isn't merged? |
I have no updates on my pull request as i just fired it into void. But I did run into one related issue worth note-ing that could also require a fix/new issue. The line_emiited signal is emitted on parse not on text update so if you hook into that symbol it also proceeds the display text by one line. |
Thanks for making this plugin. I did notice that when the end of line is reached, and the next line is loaded, the name in the nameplate is updated without waiting for a call to finish_line(). I fixed this myself by adding in a 'nextName' to YarnDisplay functioning similarly to 'nextLine', but I imagine other developers will be looking for a solution to that as well.
The text was updated successfully, but these errors were encountered: