[Chart] Policy Reporter ServiceMonitor Missing Namespace Selector

[aballman]

The template here allows you to specify a different namespace for the service monitor.

policy-reporter/charts/policy-reporter/charts/monitoring/templates/servicemonitor.yaml

Line 5 in bc7d8fb

namespace: {{ include "monitoring.smNamespace" . }}

The monitoring.smNamespace helper allows you to specify a namespace other than the .Release.Namespace or .Values.global.namespace

policy-reporter/charts/policy-reporter/charts/monitoring/templates/_helpers.tpl

Lines 61 to 69 in bc7d8fb

	{{/* Get the namespace name. */}}
	{{- define "monitoring.smNamespace" -}}
	{{- if .Values.serviceMonitor.namespace -}}
	{{- .Values.serviceMonitor.namespace -}}
	{{- else if .Values.global.namespace -}}
	{{- .Values.global.namespace -}}
	{{- else -}}
	{{- .Release.Namespace -}}
	{{- end }}

The problem being that if you do specify a different namespace than the release namespace, the service monitor will be missing anamespaceSelector in the spec that's a requirement if the serviceMonitor isn't in the same namespace as the service/endpoint

policy-reporter/charts/policy-reporter/charts/monitoring/templates/servicemonitor.yaml

Lines 15 to 34 in bc7d8fb

	spec:
	selector:
	matchLabels:
	{{- include "policyreporter.selectorLabels" . | nindent 8 }}
	endpoints:
	- port: http
	honorLabels: {{ .Values.serviceMonitor.honorLabels }}
	relabelings:
	- action: labeldrop
	regex: pod|service|container
	- targetLabel: instance
	replacement: policy-reporter
	action: replace
	{{- with .Values.serviceMonitor.relabelings }}
	{{- toYaml . | nindent 4 }}
	{{- end }}
	{{- with .Values.serviceMonitor.metricRelabelings }}
	metricRelabelings:
	{{- toYaml . | nindent 4 }}
	{{- end }}

This issue prevents prometheus from scraping the metrics endpoint

[fjogeleit]

Hey, thanks for reporting. I will have a look on it

[L1ghtman2k]

@fjogeleit How would one apply this to kyverno plugin's service monitor?

[fjogeleit]

@L1ghtman2k there is a dedicated value for the plugin service monitor within the monitoring subchart

https://github.com/kyverno/policy-reporter/blob/main/charts/policy-reporter/charts/monitoring/values.yaml#L33

[L1ghtman2k]

@L1ghtman2k there is a dedicated value for the plugin service monitor within the monitoring subchart

https://github.com/kyverno/policy-reporter/blob/main/charts/policy-reporter/charts/monitoring/values.yaml#L33

Oh, i see, I was looking for something in the values.yaml that contains "plugin". Makes sense now, thanks!