-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG Support #121
Comments
One source would be Kenney.nl's currently used crosshair pack as it contains svg editions too. Other sources of svg crosshairs? I thought we could help listing some, if you know or find others. Could submit your own packs of crosshairs too. On a separate note; this could potentially mean more customization per crosshair, since vectors are just code in the end. Example: If every crosshair uses the same (or a few similar) identifiers (id/style/? or whathaveyou) the app could have fields for editing the length/thickness/colors (or anything) features of the crosshairs. That plus a few more options like hide/opacity, probably some I can't think of right now. If no identifiers are found / some won't have it for sure (I imagine there will be plenty), easy peasy - grey those parts out when using that crosshair (and for UX perhaps a small but obvious string to tell people why options aren't available). Edit: Which gave me an extra idea: a custom code box for advanced users. Should show/allow opening of svg to see its specific layout and id's, then the user could style a crosshair that might not be supported by the defaults/home made etc. Just my 2 cents on this, hope I'm not being a bother |
Love these ideas, keep them coming! |
Original comment:
|
Thanks! I got one more just from reading my own text, I can't believe I didn't think of it at the time; Regarding my extra idea of:
Improvement to idea: Being able to edit the SVG's code themselves (without breaking them; perhaps only allow saving them as a copy/with new name - if it was edited) is enough to both allow custom styling and any other changes an advanced user would like to make. (Also, the below-mentioned SVG-parse-check should give the go-ahead when saving/before saving) In addition, perhaps this 'advanced' setting could allow you to simply paste your own SVG. I assume drag-n-dropping will also work as well with SVGs (when supported), but just sayin' in case you forget - sometimes one does simply not think of things, right?^^: CrossOver probably will need basic syntax checks on the drag-n-dropped and pasted SVG code, to make sure it's a proper SVG and the code isn't invalid or the paste is missing it's last closing bracket.... for example heh. This check should probably apply to all crosshairs that come natively, at least when they are first added - just in case, right. Avoid confusion (from users) by showing a warning if the 'upload' shows an SVG code that isn't properly made or pasted (the specific error could also be shown, I think there should be a library (or multiple) to use for these checks and parse-errors, I'm just guessing but since it's JS-based, I'm pretty sure there are plenty of options available). Extra thought about customization: Regarding SVG support - in order to actually be able to have most SVG crosshairs be customizable, they will need to have the same IDs for certain parts - so on a crosshair like mine, that would be the 4 lines having 4 different IDs that will always be the same (not the same ID for all, but the same ID for all crosshairs based on which line) no matter what crosshair it is, assuming it has lines or similar parts. I think you get what I mean. The point is that CrossOver might want to have a "best practice"-FAQ / Wiki on how to make a proper customizable SVG crosshair? I'm not sure if this would be the best way; but if a cheat-sheet for customization exists, an advanced user might be able to more easily edit an existing crosshair without knowing how to 'style' things themselves, just add/edit IDs, in the right spots... //my weekly 2 cents lol. Godspeed |
I've refactored the app and updated dependencies in prep for v3.0.0, SVG support has been added and will be available in the next version. I still need to add SVG versions of existing crosshairs and |
The [Kenney.nl Crosshair pack](https://www.kenney.nl/assets/crosshair-pack has all the SVGs in one big sprite sheet. I need someone to split these up into individual SVGs for me to use in the app. If you're good with editing software, I could use some help on this! |
Crossover doesn't cut it on high-res monitors, support vector images or use canvas
The text was updated successfully, but these errors were encountered: