Errno for timeouts #1184
Merged
Errno for timeouts #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meout It is stretching the meaning of posix codes a bit, but at least avoids inventing new ones
kornelski
added a commit
that referenced
this pull request
Mar 5, 2017
* origin/master: (32 commits) Progress event doc v3.5.0 Add errno to distinguish between request timeout and body download timeout (#1184) Warn about bogus timeout options (#1185) 3.4.4 Treat videos like images Avoid renaming module 3.4.3 3.4.3 Add node client support for bearer token authentication Add client support for bearer token authentication Fixed being able to define own parsers when their mime type starts with text/ conditional withCredentials 3.4.2 Updated dependencies Use formData.on instead of .once Ignore attach(,null) 3.4.1 Simplify check Dedupe query string append ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add errno to distinguish between response timeout and body download timeout
The existing
err.codecan't be changed, since it'd technically be a breaking change.The new
errno = ETIMEDOUTcode is almost exactly what it should be. The otherETIMEis stretching the meaning "timer expired" a bit, but at least its still a valid posix code.