From bc3cf378c2730ffcc82ae1a30408cf7866bb3360 Mon Sep 17 00:00:00 2001 From: Klaus Lungwitz <18153834+klaus993@users.noreply.github.com> Date: Fri, 11 Nov 2022 12:09:32 -0300 Subject: [PATCH 01/24] Test github actions cache for rust --- .github/workflows/rust.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 0148ec6473..580981d38d 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -24,6 +24,19 @@ jobs: uses: actions/setup-python@v4 with: python-version: '3.9' + + - name: Set up cargo cache + uses: actions/cache@v3 + continue-on-error: false + with: + path: | + ~/.cargo/bin/ + ~/.cargo/registry/index/ + ~/.cargo/registry/cache/ + ~/.cargo/git/db/ + target/ + key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} + restore-keys: ${{ runner.os }}-cargo- - name: Install test dependencies run: pip install ecdsa fastecdsa sympy cairo-lang==0.9.1 - name: format From 9227c07d6324e785ff2b5a757284727c3f35ffa6 Mon Sep 17 00:00:00 2001 From: Klaus Lungwitz <18153834+klaus993@users.noreply.github.com> Date: Fri, 11 Nov 2022 12:30:55 -0300 Subject: [PATCH 02/24] Trigger ci --- .github/workflows/bench_pull_request.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/bench_pull_request.yml b/.github/workflows/bench_pull_request.yml index ba3b2cd2c1..896b3838c2 100644 --- a/.github/workflows/bench_pull_request.yml +++ b/.github/workflows/bench_pull_request.yml @@ -2,7 +2,7 @@ name: benchmark_pr on: pull_request: - branches: [ '*' ] + branches: [ 'asd' ] jobs: build: @@ -35,4 +35,4 @@ jobs: comment-on-alert: true alert-comment-cc-users: '@unbalancedparentheses' - name: Clean benches - run: make clean \ No newline at end of file + run: make clean From 1fc2236a328fa86e0c135e24603d1dff9bbf96b6 Mon Sep 17 00:00:00 2001 From: Klaus Lungwitz <18153834+klaus993@users.noreply.github.com> Date: Fri, 11 Nov 2022 12:50:23 -0300 Subject: [PATCH 03/24] Test another cache step --- .github/workflows/rust.yml | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 580981d38d..75f5ab838c 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -25,18 +25,20 @@ jobs: with: python-version: '3.9' - - name: Set up cargo cache - uses: actions/cache@v3 - continue-on-error: false - with: - path: | - ~/.cargo/bin/ - ~/.cargo/registry/index/ - ~/.cargo/registry/cache/ - ~/.cargo/git/db/ - target/ - key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} - restore-keys: ${{ runner.os }}-cargo- + - uses: Swatinem/rust-cache@v2 + +# - name: Set up cargo cache +# uses: actions/cache@v3 +# continue-on-error: false +# with: +# path: | +# ~/.cargo/bin/ +# ~/.cargo/registry/index/ +# ~/.cargo/registry/cache/ +# ~/.cargo/git/db/ +# target/ +# key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} +# restore-keys: ${{ runner.os }}-cargo- - name: Install test dependencies run: pip install ecdsa fastecdsa sympy cairo-lang==0.9.1 - name: format From b34091307a212797f5645832bc0fe9fdfad031df Mon Sep 17 00:00:00 2001 From: Klaus Lungwitz <18153834+klaus993@users.noreply.github.com> Date: Fri, 11 Nov 2022 13:08:06 -0300 Subject: [PATCH 04/24] Trigger ci --- .github/workflows/bench_pull_request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/bench_pull_request.yml b/.github/workflows/bench_pull_request.yml index 896b3838c2..4e5ca863b7 100644 --- a/.github/workflows/bench_pull_request.yml +++ b/.github/workflows/bench_pull_request.yml @@ -2,7 +2,7 @@ name: benchmark_pr on: pull_request: - branches: [ 'asd' ] + branches: [ 'asfd' ] jobs: build: From a2380113355e8eeff9d1ccf68301fb178e01b6e6 Mon Sep 17 00:00:00 2001 From: Klaus Lungwitz <18153834+klaus993@users.noreply.github.com> Date: Fri, 11 Nov 2022 13:13:36 -0300 Subject: [PATCH 05/24] Add cache step --- .github/workflows/rust.yml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 75f5ab838c..7790018459 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -53,6 +53,25 @@ jobs: run: make clippy - name: Coverage run: make coverage + + - uses: Swatinem/rust-cache@v2 + + - name: Cleanup tests + run: make clean + - name: Cache Codecov-report + uses: actions//upload-artifact@master + with: + name: codecov-report + path: target/tarpaulin + upload-codecov: + needs: build + runs-on: ubuntu-20.04 + steps: + - name: Retrieve cached report + uses: actions/download-artifact@master + with: + name: codecov-report + path: target/tarpaulin - name: Upload coverage to codecov.io uses: codecov/codecov-action@v3 with: From 05cb95e21f9c35c92e0451a105520616c068a5e5 Mon Sep 17 00:00:00 2001 From: Klaus Lungwitz <18153834+klaus993@users.noreply.github.com> Date: Fri, 11 Nov 2022 13:39:26 -0300 Subject: [PATCH 06/24] Back to testing actions/cache --- .github/workflows/rust.yml | 31 +++++++++++++++---------------- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 7790018459..159a478edc 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -25,20 +25,22 @@ jobs: with: python-version: '3.9' - - uses: Swatinem/rust-cache@v2 + - name: Set up cargo cache + uses: actions/cache@v3 + continue-on-error: false + with: + path: | + /home/runner/.cargo/bin/ + /home/runner/.cargo/registry/index/ + /home/runner/.cargo/registry/cache/ + /home/runner/.cargo/git/db/ + /home/runner/work/cairo-rs/cairo-rs/target + target/ + key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} + restore-keys: | + ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} + ${{ runner.os }}-cargo- -# - name: Set up cargo cache -# uses: actions/cache@v3 -# continue-on-error: false -# with: -# path: | -# ~/.cargo/bin/ -# ~/.cargo/registry/index/ -# ~/.cargo/registry/cache/ -# ~/.cargo/git/db/ -# target/ -# key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} -# restore-keys: ${{ runner.os }}-cargo- - name: Install test dependencies run: pip install ecdsa fastecdsa sympy cairo-lang==0.9.1 - name: format @@ -53,9 +55,6 @@ jobs: run: make clippy - name: Coverage run: make coverage - - - uses: Swatinem/rust-cache@v2 - - name: Cleanup tests run: make clean - name: Cache Codecov-report From b0daecc4cef73e4f514c46d1c02968f1d2567683 Mon Sep 17 00:00:00 2001 From: Klaus Lungwitz <18153834+klaus993@users.noreply.github.com> Date: Fri, 11 Nov 2022 14:40:34 -0300 Subject: [PATCH 07/24] Trigger ci --- .github/workflows/rust.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 159a478edc..de5442430e 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -37,9 +37,7 @@ jobs: /home/runner/work/cairo-rs/cairo-rs/target target/ key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} - restore-keys: | - ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} - ${{ runner.os }}-cargo- + restore-keys: ${{ runner.os }}-cargo- - name: Install test dependencies run: pip install ecdsa fastecdsa sympy cairo-lang==0.9.1 From 11b883daa790b586e5cdba3e516be134d501d37c Mon Sep 17 00:00:00 2001 From: Klaus Lungwitz <18153834+klaus993@users.noreply.github.com> Date: Fri, 11 Nov 2022 14:41:27 -0300 Subject: [PATCH 08/24] Test path --- .github/workflows/rust.yml | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index de5442430e..74b42914b0 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -30,12 +30,11 @@ jobs: continue-on-error: false with: path: | - /home/runner/.cargo/bin/ - /home/runner/.cargo/registry/index/ - /home/runner/.cargo/registry/cache/ - /home/runner/.cargo/git/db/ - /home/runner/work/cairo-rs/cairo-rs/target - target/ + ~/.cargo/bin/ + ~/.cargo/registry/index/ + ~/.cargo/registry/cache/ + ~/.cargo/git/db/ + #target/ key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} restore-keys: ${{ runner.os }}-cargo- From e694a7372ce483b92f9ff52190a2c5b31c7fbe54 Mon Sep 17 00:00:00 2001 From: Klaus Lungwitz <18153834+klaus993@users.noreply.github.com> Date: Tue, 15 Nov 2022 15:18:22 -0300 Subject: [PATCH 09/24] Test --- .github/workflows/rust.yml | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 74b42914b0..c133fec2e6 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -26,17 +26,20 @@ jobs: python-version: '3.9' - name: Set up cargo cache - uses: actions/cache@v3 - continue-on-error: false - with: - path: | - ~/.cargo/bin/ - ~/.cargo/registry/index/ - ~/.cargo/registry/cache/ - ~/.cargo/git/db/ - #target/ - key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} - restore-keys: ${{ runner.os }}-cargo- + uses: Swatinem/rust-cache@v2 + +# - name: Set up cargo cache +# uses: actions/cache@v3 +# continue-on-error: false +# with: +# path: | +# ~/.cargo/bin/ +# ~/.cargo/registry/index/ +# ~/.cargo/registry/cache/ +# ~/.cargo/git/db/ +# #target/ +# key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} +# restore-keys: ${{ runner.os }}-cargo- - name: Install test dependencies run: pip install ecdsa fastecdsa sympy cairo-lang==0.9.1 From b1dd816884d3482b648c7995ee59b786e2d9e793 Mon Sep 17 00:00:00 2001 From: Klaus Lungwitz <18153834+klaus993@users.noreply.github.com> Date: Tue, 15 Nov 2022 15:54:15 -0300 Subject: [PATCH 10/24] Debug step --- .github/workflows/rust.yml | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index c133fec2e6..ac35d5e696 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -25,21 +25,17 @@ jobs: with: python-version: '3.9' - - name: Set up cargo cache - uses: Swatinem/rust-cache@v2 + - name: Debug + run: which rustfmt && which rustc -# - name: Set up cargo cache -# uses: actions/cache@v3 -# continue-on-error: false -# with: -# path: | -# ~/.cargo/bin/ -# ~/.cargo/registry/index/ -# ~/.cargo/registry/cache/ -# ~/.cargo/git/db/ -# #target/ -# key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} -# restore-keys: ${{ runner.os }}-cargo- + - name: Set up cargo cache + uses: actions/cache@v3 + continue-on-error: false + with: + path: | + ~/.cargo + key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} + restore-keys: ${{ runner.os }}-cargo- - name: Install test dependencies run: pip install ecdsa fastecdsa sympy cairo-lang==0.9.1 From 55fedcffb058d88f0db215201769b1cdf9b24344 Mon Sep 17 00:00:00 2001 From: Juan-M-V <102986292+Juan-M-V@users.noreply.github.com> Date: Wed, 16 Nov 2022 17:03:11 -0300 Subject: [PATCH 11/24] Update rust.yml --- .github/workflows/rust.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index ac35d5e696..fd75ff609b 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -25,9 +25,6 @@ jobs: with: python-version: '3.9' - - name: Debug - run: which rustfmt && which rustc - - name: Set up cargo cache uses: actions/cache@v3 continue-on-error: false From e7e2027b9ad4f65641df1f54e42cde588f17bbbf Mon Sep 17 00:00:00 2001 From: Juan-M-V <102986292+Juan-M-V@users.noreply.github.com> Date: Wed, 16 Nov 2022 17:03:27 -0300 Subject: [PATCH 12/24] Update bench_pull_request.yml --- .github/workflows/bench_pull_request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/bench_pull_request.yml b/.github/workflows/bench_pull_request.yml index 4e5ca863b7..81ef6c3ef5 100644 --- a/.github/workflows/bench_pull_request.yml +++ b/.github/workflows/bench_pull_request.yml @@ -2,7 +2,7 @@ name: benchmark_pr on: pull_request: - branches: [ 'asfd' ] + branches: [ '*' ] jobs: build: From 593a4aae2712c2f88ad365379cbc72deafc95f0d Mon Sep 17 00:00:00 2001 From: "Mario J. Rugiero" Date: Fri, 18 Nov 2022 07:49:33 -0300 Subject: [PATCH 13/24] Test target without tarpaulin --- .github/workflows/rust.yml | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index fd75ff609b..20a33af7b9 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -31,6 +31,8 @@ jobs: with: path: | ~/.cargo + target/debug + target/release key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} restore-keys: ${{ runner.os }}-cargo- @@ -50,12 +52,13 @@ jobs: run: make coverage - name: Cleanup tests run: make clean - - name: Cache Codecov-report - uses: actions//upload-artifact@master - with: - name: codecov-report - path: target/tarpaulin + #- name: Cache Codecov-report + #uses: actions//upload-artifact@master + #with: + ##name: codecov-report + #path: target/tarpaulin upload-codecov: + if: false needs: build runs-on: ubuntu-20.04 steps: From b73d21a7e7f047e3fa96f11973432c638aa5cc3a Mon Sep 17 00:00:00 2001 From: "Mario J. Rugiero" Date: Fri, 18 Nov 2022 08:02:12 -0300 Subject: [PATCH 14/24] Debug --- .github/workflows/rust.yml | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 20a33af7b9..91a237ed1e 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -30,9 +30,9 @@ jobs: continue-on-error: false with: path: | - ~/.cargo - target/debug - target/release + ~/.cargo/ + target/debug/ + target/release/ key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} restore-keys: ${{ runner.os }}-cargo- @@ -48,10 +48,16 @@ jobs: run: make compare_trace_memory - name: Run clippy run: make clippy + - name: Debug permissions + run: | + ls -lah target/ + ls -lah target/debug/ - name: Coverage run: make coverage - - name: Cleanup tests - run: make clean + - name: Debug permissions + run: | + ls -lah target/ + ls -lah target/debug/ #- name: Cache Codecov-report #uses: actions//upload-artifact@master #with: From a66b1995ac0d81b668affff948d784f71f09af44 Mon Sep 17 00:00:00 2001 From: "Mario J. Rugiero" Date: Fri, 18 Nov 2022 09:03:16 -0300 Subject: [PATCH 15/24] Don't include lockfiles from targets --- .github/workflows/rust.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 91a237ed1e..3be7457d4a 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -33,6 +33,7 @@ jobs: ~/.cargo/ target/debug/ target/release/ + !target/**.lock key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} restore-keys: ${{ runner.os }}-cargo- From f52f449b25bfb6b2bd883590ac6645e351220417 Mon Sep 17 00:00:00 2001 From: "Mario J. Rugiero" Date: Fri, 18 Nov 2022 09:29:15 -0300 Subject: [PATCH 16/24] Restrict cache targets to avoid complicated permissions issues --- .github/workflows/rust.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 3be7457d4a..058a054b4a 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -30,10 +30,12 @@ jobs: continue-on-error: false with: path: | - ~/.cargo/ - target/debug/ - target/release/ - !target/**.lock + ~/.cargo/bin/ + ~/.cargo/registry/index/ + ~/.cargo/registry/cache/ + ~/.cargo/git/db/ + target/debug/deps/ + target/release/deps/ key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} restore-keys: ${{ runner.os }}-cargo- From 7f30c1a4d8063aa744aa62e5cd11fdde3ac3fb0c Mon Sep 17 00:00:00 2001 From: "Mario J. Rugiero" Date: Fri, 18 Nov 2022 10:27:04 -0300 Subject: [PATCH 17/24] Include build --- .github/workflows/rust.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 058a054b4a..a6a1498b8d 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -35,7 +35,9 @@ jobs: ~/.cargo/registry/cache/ ~/.cargo/git/db/ target/debug/deps/ + target/debug/build/ target/release/deps/ + target/release/build/ key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} restore-keys: ${{ runner.os }}-cargo- From f66827658fc7f0c2813ff1da278e538318cc0f78 Mon Sep 17 00:00:00 2001 From: "Mario J. Rugiero" Date: Fri, 18 Nov 2022 11:35:25 -0300 Subject: [PATCH 18/24] Include incremental build :fingers-crossed: --- .github/workflows/rust.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index a6a1498b8d..d909d98493 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -36,8 +36,12 @@ jobs: ~/.cargo/git/db/ target/debug/deps/ target/debug/build/ + target/debug/examples/ + target/debug/incremental/*/*/ target/release/deps/ target/release/build/ + target/release/examples/ + target/release/incremental/*/*/ key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} restore-keys: ${{ runner.os }}-cargo- From 90813a9312ea7f16bc93600c4827ca3d6400c3b1 Mon Sep 17 00:00:00 2001 From: "Mario J. Rugiero" Date: Fri, 18 Nov 2022 14:42:04 -0300 Subject: [PATCH 19/24] Incremental won't work anyway --- .github/workflows/rust.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index d909d98493..6099da5982 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -37,11 +37,9 @@ jobs: target/debug/deps/ target/debug/build/ target/debug/examples/ - target/debug/incremental/*/*/ target/release/deps/ target/release/build/ target/release/examples/ - target/release/incremental/*/*/ key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} restore-keys: ${{ runner.os }}-cargo- From 15454b0ec42d2f31d6c8bf769749a526099bb761 Mon Sep 17 00:00:00 2001 From: "Mario J. Rugiero" Date: Fri, 18 Nov 2022 14:43:19 -0300 Subject: [PATCH 20/24] Enable codecov --- .github/workflows/rust.yml | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 6099da5982..7da6844dd1 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -55,21 +55,13 @@ jobs: run: make compare_trace_memory - name: Run clippy run: make clippy - - name: Debug permissions - run: | - ls -lah target/ - ls -lah target/debug/ - name: Coverage run: make coverage - - name: Debug permissions - run: | - ls -lah target/ - ls -lah target/debug/ - #- name: Cache Codecov-report - #uses: actions//upload-artifact@master - #with: - ##name: codecov-report - #path: target/tarpaulin + - name: Cache Codecov-report + uses: actions//upload-artifact@master + with: + name: codecov-report + path: target/tarpaulin upload-codecov: if: false needs: build From 6ef009f84efe664a404cb36a3927a4d02b718e1d Mon Sep 17 00:00:00 2001 From: "Mario J. Rugiero" Date: Fri, 18 Nov 2022 14:45:19 -0300 Subject: [PATCH 21/24] Clean --- .github/workflows/rust.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 7da6844dd1..7d10738793 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -63,7 +63,6 @@ jobs: name: codecov-report path: target/tarpaulin upload-codecov: - if: false needs: build runs-on: ubuntu-20.04 steps: @@ -76,5 +75,3 @@ jobs: uses: codecov/codecov-action@v3 with: fail_ci_if_error: true - - name: Cleanup tests - run: make clean From 3470a8fb71333e8c85a829672d43d94f080bd03b Mon Sep 17 00:00:00 2001 From: "Mario J. Rugiero" Date: Fri, 18 Nov 2022 18:36:11 -0300 Subject: [PATCH 22/24] Fix --- .github/workflows/rust.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 7d10738793..7b43f0a24f 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -59,9 +59,9 @@ jobs: run: make coverage - name: Cache Codecov-report uses: actions//upload-artifact@master - with: - name: codecov-report - path: target/tarpaulin + with: + name: codecov-report + path: target/tarpaulin upload-codecov: needs: build runs-on: ubuntu-20.04 From afb9fd1ddec2b815442aa358dfda296483de2728 Mon Sep 17 00:00:00 2001 From: "Mario J. Rugiero" Date: Tue, 22 Nov 2022 09:16:01 -0300 Subject: [PATCH 23/24] Remove spurious separator --- .github/workflows/rust.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 7b43f0a24f..12159f88d1 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -58,7 +58,7 @@ jobs: - name: Coverage run: make coverage - name: Cache Codecov-report - uses: actions//upload-artifact@master + uses: actions/upload-artifact@master with: name: codecov-report path: target/tarpaulin From 0b37a307de2653c3bdad38f4396a86790f27c463 Mon Sep 17 00:00:00 2001 From: "Mario J. Rugiero" Date: Tue, 22 Nov 2022 09:16:29 -0300 Subject: [PATCH 24/24] Only cache deps As explained in Swatinem/rust-cache#37, build artifacts only contribute to bloating the cache, as the divergences negate any benefits from caching them due to the cache key not changing over most commits. --- .github/workflows/rust.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 12159f88d1..e9539e5203 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -35,11 +35,7 @@ jobs: ~/.cargo/registry/cache/ ~/.cargo/git/db/ target/debug/deps/ - target/debug/build/ - target/debug/examples/ target/release/deps/ - target/release/build/ - target/release/examples/ key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} restore-keys: ${{ runner.os }}-cargo-