Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Deploy transaction is not _declaring_ the class #834

Closed
Tracked by #1287
kkovaacs opened this issue Jul 18, 2023 · 1 comment · Fixed by #865
Closed
Tracked by #1287

Deploy transaction is not _declaring_ the class #834

kkovaacs opened this issue Jul 18, 2023 · 1 comment · Fixed by #865
Assignees

Comments

@kkovaacs
Copy link
Contributor

While using the re-execution tool I've found that Deploy transactions are not working: it looks like Deploy is missing the step of actually declaring the class.

The Deploy transaction actually did declare the class and deployed a contract with the class just declared. Currently the code seems to do just the second step -- which won't work because the class is not really added to state.

@kkovaacs
Copy link
Contributor Author

Adding a state.set_contract_class(&self.contract_hash, &self.contract_class) call to Deploy.apply() seems to fix the issue (after adding self.contract_class that contains the actual class definition of course).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants