Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the collector crate public #21

Open
popadi opened this issue May 4, 2023 · 1 comment
Open

Make the collector crate public #21

popadi opened this issue May 4, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@popadi
Copy link

popadi commented May 4, 2023

Any chance to make the collector sub-module public? I'm interested in using the collect method to retrieve an instance of a Metrics struct and then expose it.

Why? My app is using prometheus/client_rust instead of metrics-exporter-prometheus, so the metrics export needs to be a bit different (more info about the Collector trait here, if you are interested). I could benefit from reusing some of the structs and functions defined in that sub-module.

@lambdalisue
Copy link
Owner

There is no particularly strong reason to do this, so if there is a PR with well-written documentation comments, we will review it 👍

@lambdalisue lambdalisue added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants