Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify 4.0.x branch against real-world applications before releasing #64

Closed
Ocramius opened this issue Dec 9, 2020 · 3 comments
Closed
Assignees
Milestone

Comments

@Ocramius
Copy link
Member

Ocramius commented Dec 9, 2020

Feature Request

Q A
New Feature no
RFC yes
BC Break no

Summary

Before releasing to 4.0.x, we need to first test this in the wild with newer PHP 8.0 features.

Most notably, @Ocramius specifically will integrate the component with ocramius/proxy-manager before calling it "ready for 8.0", due to downstream CI pipeline being extremely strict.

@Ocramius Ocramius added this to the 4.0.0 milestone Dec 9, 2020
@Ocramius Ocramius self-assigned this Dec 9, 2020
@martinssipenko
Copy link

martinssipenko commented Dec 18, 2020

I tried using laminas/laminas-code 4.x branch with ocramius/proxy-manager.

Using ocramius/proxy-manager:2.11.x as base:
Ocramius/ProxyManager#637

Using 8.0 patch as base:
Ocramius/ProxyManager#639

Also tried using 4.x on laminas-server:
laminas/laminas-server#21

@martinssipenko
Copy link

Is this enough for 4.0 release or is there anything else I could do?

@Ocramius
Copy link
Member Author

Tested this carefully - works as expected, so 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants