Drop or upgrade Laminas\Math

[gsteel]

Feature Request

Q	A
New Feature	yes

Summary

Validator is stuck on Laminas\Math 2.x. It only uses it for random bytes in the CSRF validator and using v2 drags in laminas/laminas-zendframework-bridge.

Since PHP ^7 comes with random_bytes, it should be possible to drop math altogether, or alternatively upgrade to 3.x

laminas-validator/src/Csrf.php

Lines 302 to 318 in 4875d4e

	protected function generateHash()
	{
	$token = md5($this->getSalt() . Rand::getBytes(32) . $this->getName());
	$this->hash = $this->formatHash($token, $this->generateTokenId());
	$this->setValue($this->hash);
	$this->initCsrfToken();
	}
	/**
	* @return string
	*/
	protected function generateTokenId()
	{
	return md5(Rand::getBytes(32));
	}

[Ocramius]

We can use random_bytes() indeed 👍

Rand::getBytes() was only relevant in a pre-php7 era. /cc @ezimuel if you want to confirm that :D