Fix goto-def on exported forwarders #19494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
changed the title
Given:
class Foo(name: String, age: Int)
case class Person(name: String)
Is the Foo constructor symbol synthetic? Being the primary
constructor, sourceSymbol considers it should be substituted for the Foo
class symbol.
Similarly, the Person apply method symbol is replaced by the class
symbol for Person (via the Person module class).
Doing so leads the presentation compiler to show details about the
class, rather than the constructor or the apply method intially
targeted.
dwijnand
force-pushed
the
export-completions
branch
from
82c54a9 to
c998f47
Compare
dwijnand
force-pushed
the
export-completions
branch
from
083c776 to
4e532e9
Compare
dwijnand
force-pushed
the
export-completions
branch
from
434f066 to
050d11d
Compare
dwijnand
changed the title
|
@odersky let me know if you can spot a better way to do this, or any tweaks in how I do it. |
tgodzik
approved these changes
Jan 29, 2024
tgodzik
added
backport:nominated
Tested by giving exportTerm0 and exportTerm1 difference filenames, resulting in different locations and breakage.
tgodzik
removed
the
backport:nominated
WojciechMazur
added a commit
that referenced
this pull request
Jul 1, 2024
Backports #19494 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.