Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit switch bytecode when matching unions of a switchable type #20411

Merged
merged 3 commits into from
May 22, 2024
Merged

Emit switch bytecode when matching unions of a switchable type #20411

merged 3 commits into from
May 22, 2024

Conversation

dwickern
Copy link
Contributor

Fixes #20410

@smarter
Copy link
Member

smarter commented May 16, 2024

The CLA check is failing, would you mind signing the CLA at https://www.lightbend.com/contribute/cla/scala ?

@dwickern
Copy link
Contributor Author

The CLA check is failing, would you mind signing the CLA at https://www.lightbend.com/contribute/cla/scala ?

👍 Signed

@dwickern dwickern marked this pull request as ready for review May 17, 2024 16:43
smarter
smarter approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@smarter smarter merged commit e0c030c into scala:main May 22, 2024
19 checks passed
@dwickern dwickern deleted the union-switch branch May 22, 2024 21:44
@Kordyjan Kordyjan added this to the 3.5.1 milestone Jul 3, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jul 8, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 8, 2024
@WojciechMazur
Backport "Emit switch bytecode when matching unions of a switchable t…
d260b21 
…ype" to LTS (#21118)

Backports #20411 to the LTS branch.

PR submitted by the release tooling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd left review comments

@smarter smarter smarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.1
Development

Successfully merging this pull request may close these issues.

Emit switch bytecode when matching unions of a switchable type
4 participants
@dwickern @smarter @sjrd @Kordyjan