Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Profile Options not Fully Merging #40

Closed
wants to merge 2 commits into from
Closed

Fix for Profile Options not Fully Merging #40

wants to merge 2 commits into from

Conversation

jayclassless
Copy link
Contributor

When setting up custom profile.yaml files for my projects, I found that the options I was setting for pylint weren't being respected. After some digging, I found that the merging functionality didn't seem to do what it needed to do in order to carry my options over.

The tests around profiles and merging still pass (after modifying one due to removing some functionality in _merge_dict), and my custom profiles are now working as expected. But, you may want to poke at this a bit more to see if I missed something.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) when pulling 389e3e2 on jayclassless:profile_merge_fixes into 1d67804 on landscapeio:master.

@carlio
Copy link
Contributor

carlio commented Sep 25, 2014

I can't quite remember the logic for the dict1_priority stuff, but I guess it was used. Could you add a test case (even just a failing one) to show the problem you're seeing?

@coveralls
Copy link

Coverage Status

Coverage increased (+1.38%) when pulling 8e1dff7 on jayclassless:profile_merge_fixes into 1d67804 on landscapeio:master.

@jayclassless
Copy link
Contributor Author

I added a test case. It runs through loading a standard profile, loading a custom profile, and then merging the two. When run on the master branch, this test case fails, as merged_profile contains the pylint options from the standard profile instead of the custom one.

carlio added a commit to carlio/prospector that referenced this pull request Jan 5, 2015
…ofiles are parsed and combined. This fixes problems with merging and introduces "shorthand" attributes, which are essentially user-friendly ways of inheriting the built-in prospector profiles
@carlio
Copy link
Contributor

carlio commented Jan 31, 2015

I ended up rewriting most of how profiles work, so I think your inheritance issue will now be solved.

Or worse, but I hope solved.

@carlio carlio closed this Jan 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants