Redis Vectorstore: Redis.from_texts_return_keys() got multiple values for argument 'cls'

[iamadhee]

System Info

Python 3.10.4
langchain==0.0.171
redis==3.5.3
redisearch==2.1.1

Who can help?

@tylerhutcherson

Information

• The official example notebooks/scripts
• My own modified scripts

Related Components

• LLMs/Chat Models
• Embedding Models
• Prompts / Prompt Templates / Prompt Selectors
• Output Parsers
• Document Loaders
• Vector Stores / Retrievers
• Memory
• Agents / Agent Executors
• Tools / Toolkits
• Chains
• Callbacks/Tracing
• Async

Reproduction

I was able to override issue #3893 by temporarily disabling the _check_redis_module_exist, post which I'm getting the below error when calling the from_texts_return_keys within the from_documents method in Redis class. Seems the argument cls is not needed in the from_texts_return_keys method, since it is already defined as a classmethod.

File "/workspaces/chatdataset_backend/adapters.py", line 96, in load
    vectorstore = self.rds.from_documents(documents=documents, embedding=self.embeddings)
  File "/home/codespace/.python/current/lib/python3.10/site-packages/langchain/vectorstores/base.py", line 296, in from_documents
    return cls.from_texts(texts, embedding, metadatas=metadatas, **kwargs)
  File "/home/codespace/.python/current/lib/python3.10/site-packages/langchain/vectorstores/redis.py", line 448, in from_texts
    instance, _ = cls.from_texts_return_keys(
TypeError: Redis.from_texts_return_keys() got multiple values for argument 'cls'

Expected behavior

Getting rid of cls argument from all the Redis class methods wherever required. Was able to solve the issue with this fix.

[tylerhutcherson]

This is a high priority issue. I ran into this myself yesterday.

Thanks for creating the issue.

[iamadhee]

Thanks, @tylerhutcherson If you could assign this to me, I can solve it along with #4899 and merge it.

[tylerhutcherson]

Yes, please do. Add unit tests to catch similar issues if you can. Tag me in the PR review!

[tylerhutcherson]

@iamadhee FYI #4

[iamadhee]

@tylerhutcherson Have added #4932

[dosubot]

Hi, @iamadhee! I'm Dosu, and I'm helping the LangChain team manage their backlog. I wanted to let you know that we are marking this issue as stale.

From what I understand, the issue you reported was about the from_texts_return_keys() method in the Redis class receiving multiple values for the cls argument. Tylerhutcherson confirmed the issue and suggested removing the cls argument from all the Redis class methods where it is not needed. You agreed to solve the issue and merge it along with another one. Tylerhutcherson asked for unit tests and requested to be tagged in the PR review. You added a PR and updated Tylerhutcherson.

Before we close this issue, we wanted to check if it is still relevant to the latest version of the LangChain repository. If it is, please let us know by commenting on the issue. Otherwise, feel free to close the issue yourself, or it will be automatically closed in 7 days.

Thank you for your contribution to the LangChain repository!