Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: Add Naver chat model & embeddings #25047

Closed

Conversation

hyper-clova
Copy link

@hyper-clova hyper-clova commented Aug 5, 2024

Description

Twitter handle:

Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 11:06am

@hyper-clova hyper-clova marked this pull request as ready for review August 6, 2024 01:50
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. community Related to langchain-community Ɑ: embeddings Related to text embedding models module 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Aug 6, 2024
@efriis
Copy link
Member

efriis commented Aug 6, 2024

howdy! could you reopen this from a personal repo instead of an organization one? https://python.langchain.com/v0.2/docs/contributing/faq/#how-do-i-allow-maintainers-to-edit-my-pr

this helps us collaborate on the code in your PR :)

one question on namespaces - would it make sense to have these in .clova namespaces instead of .naver?

also, could you clarify the difference between ClovaEmbeddings and ClovaXEmbeddings?

@hyper-clova
Copy link
Author

could you reopen this from a personal repo instead of an organization one?

another PR(#25162) is reopen.

one question on namespaces - would it make sense to have these in .clova namespaces instead of .naver?

I would like to keep it as is, unless it is essential to unify the package name.
(ClovaX is a branding for the model, and I plan to add other models and components. They need to be managed as separate classes.)

also, could you clarify the difference between ClovaEmbeddings and ClovaXEmbeddings?

There are 3 models that are being serviced by embedding, and all are supported in the current PR. In addition, all the functionality of CLOVA Studio that serves actual models, such as distinguishing between test apps and service apps, is supported. The existing PR does not support this content because it is hard-coded.

@hyper-clova hyper-clova closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community Ɑ: embeddings Related to text embedding models module 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants