Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: Add Naver chat model & embeddings #25162

Open
wants to merge 41 commits into
base: master
Choose a base branch
from

Conversation

hyper-clova
Copy link

@hyper-clova hyper-clova commented Aug 8, 2024

Reopened as a personal repo outside the organization.

Description

Twitter handle: None. (if needed, contact with joonha.jeon@navercorp.com)


you can check our previous discussion below:

one question on namespaces - would it make sense to have these in .clova namespaces instead of .naver?

I would like to keep it as is, unless it is essential to unify the package name.
(ClovaX is a branding for the model, and I plan to add other models and components. They need to be managed as separate classes.)

also, could you clarify the difference between ClovaEmbeddings and ClovaXEmbeddings?

There are 3 models that are being serviced by embedding, and all are supported in the current PR. In addition, all the functionality of CLOVA Studio that serves actual models, such as distinguishing between test apps and service apps, is supported. The existing PR does not support this content because it is hard-coded.

Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 6:42pm

@hyper-clova
Copy link
Author

Hello @efriis,

We've been preparing for this community package and waiting for review (following up our prior communication on early August via email), and I think we are all ready to go!

Could you check this PR?

@efriis
Copy link
Member

efriis commented Aug 29, 2024

Thanks for the ping! Could you get CI passing?

@hyper-clova
Copy link
Author

Thanks @efriis , seems we referred to some outdated docs, got failed linting test.
Now fixed!

Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guessing there will be a sizable number of CI failures on this - feel free to click in and see the issues! To run linting+testing yourself locally you can

cd libs/community
poetry install --with lint,typing --sync
make lint

and

cd libs/community
poetry install --with lint,typing,test
make test

libs/community/langchain_community/chat_models/naver.py Outdated Show resolved Hide resolved
libs/community/langchain_community/chat_models/naver.py Outdated Show resolved Hide resolved
libs/community/langchain_community/chat_models/naver.py Outdated Show resolved Hide resolved
libs/community/langchain_community/embeddings/clova.py Outdated Show resolved Hide resolved
libs/community/langchain_community/embeddings/naver.py Outdated Show resolved Hide resolved
@efriis
Copy link
Member

efriis commented Sep 20, 2024

also pinged you on slack for an api key for testing!

@efriis
Copy link
Member

efriis commented Sep 20, 2024

actually scratch the api key - let's address the above comments and get CI passing!

@hyper-clova
Copy link
Author

also pinged you on slack for an api key for testing!

�Could you please guide me to the Slack channel? I don't know where it is.

@efriis
Copy link
Member

efriis commented Sep 23, 2024

You responded to me on Friday! Is this Joonha?

@hyper-clova
Copy link
Author

hyper-clova commented Sep 24, 2024

You responded to me on Friday! Is this Joonha?

@efriis , Sorry for any confusion. This is our team account and there was a little communication gap between us. Checked Joonha (PM) has sent you the api key :)

Done with all review comments, and also got no fail when linting + testing from our own, so I think it's good to go!

@hyper-clova hyper-clova force-pushed the feat/package-naver-v1 branch 2 times, most recently from c1b142c to d3b2de6 Compare September 24, 2024 06:23
@hyper-clova
Copy link
Author

Hi @efriis , I think we missed the release v0.3.1 for langchain-community. Do you plan this to be included in v0.3.2?

  • Just noticed an issue (Add Support for Additional Clova Embedding Models #26695 ) that tries to add on existing embedding component (ClovaEmbeddings) due to high demand of using langchain with our APIs, however, the existing one should be deprecated due to the reason we mentioned before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community Ɑ: embeddings Related to text embedding models module 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants