core: Add various ruff rules #26836
Open
core: Add various ruff rules #26836
+104
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:L
cbornet
force-pushed
the
ruff-rules-multi
branch
4 times, most recently
from
30b57a4
to
540635a
Compare
eyurtsev
reviewed
Sep 26, 2024
| @@ -291,9 +292,14 @@ async def _render_mermaid_using_pyppeteer( | |||
| img_bytes = await page.screenshot({"fullPage": False}) | |||
| await browser.close() | |||
|
|
|||
| def write_to_file(path: str, bytes: bytes) -> None: | |||
There was a problem hiding this comment.
is this from a ruff rule?
There was a problem hiding this comment.
Yes because we are in an async context so we can’t use blocking open() and write() directly (ruff rule ASYNC)
|
@cbornet looks good -- what fraction of these have corresponding auto-formatting if any? |
|
Auto-fix is mostly |
cbornet
force-pushed
the
ruff-rules-multi
branch
3 times, most recently
from
b65fd5a
to
88f1e9f
Compare
cbornet
force-pushed
the
ruff-rules-multi
branch
from
88f1e9f
to
f04a6af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.