Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noProrate() not working while updating quantity of a multiplan item #923

Closed
rambo666 opened this issue Apr 27, 2020 · 2 comments · Fixed by #924
Closed

noProrate() not working while updating quantity of a multiplan item #923

rambo666 opened this issue Apr 27, 2020 · 2 comments · Fixed by #924
Labels

Comments

@rambo666
Copy link

  • Cashier Version: 11.2.1
  • Laravel Version: 6.18.10
  • PHP Version: 7.2

Description:

While I update a plan quantity belonging to a multiplan subscriptin. Putting noProrate does not work. After I went to the stripe I can still see remaining time of quantity being invoiced.

I used the following code to update quantity for my plan
$user->subscription('default')->noProrate()->updateQuantity($qty,$subscriptionPlan)

Even though I used noProrate() the invoice on stripe was still prorating and showing remaining time of quantity on the invoice.

Steps To Reproduce:

Apply no prorate while updating quantity on stripe while there are multiplans on a subscription.

@driesvints
Copy link
Member

Thanks, I also see the problem here. You've been very helpful so far, thanks!

@driesvints
Copy link
Member

Sent in a PR for this: #924

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants