PHP attributes Override >= 8.3 & Deprecated >=8.4 are the only php attributes that are usable without a non attributes alternative? Any other ideas? #52193
Replies: 5 comments 8 replies
-
|
ArrayShape. For intelligence. No reflection needed, as it is for IDE's |
Beta Was this translation helpful? Give feedback.
-
|
With the mention that this is not a native attribute of php but a class from |
Beta Was this translation helpful? Give feedback.
-
|
Indeed, but it would be nice if other ide's can interpret those too. |
Beta Was this translation helpful? Give feedback.
-
|
Got another use case. In my newly build package I have created an EncryptsData Attribute. The only moment it is used is when you rotate the encryption on your models where you have a mutator that handles encryption. You can also avoid it by creating a full cast object. https://packagist.org/packages/henzeb/laravel-encrypted-data-rotator I think its an exception to the rule. It is not affecting performance of your application when used in a command line or queue. |
Beta Was this translation helpful? Give feedback.
-
|
Nice. It is a case used only when you rotate by running that command. I am just curious. Is this the only solution to solve this problem? I understand that it must run only when you run the command and not when the application is running. |
Beta Was this translation helpful? Give feedback.
-
|
there is also a solution to add a parameter with a list of mutators, but I find that a bit messy. the casts are also automatically detected. I doubt there are problems that only have one solution that involves Attributes anyway. |
Beta Was this translation helpful? Give feedback.
-
|
I see it as an acceptable exception to use attributes on something (as "flags") that will be discovered only on certain manual initiated actions and not on each request because they will not add any overhead to the execution code in normal circumstances. |
Beta Was this translation helpful? Give feedback.
-
|
@henzeb a colleague found another use case. Open api generation of swagger documentation via attributes. It is under the same logic as is your example for one time command for encrypting data. |
Beta Was this translation helpful? Give feedback.
-
|
@henzeb bad news
|
Beta Was this translation helpful? Give feedback.
-
|
Yeah I saw it. I wonder how much impact this would actually have even when not used. |
Beta Was this translation helpful? Give feedback.
-
|
If this will be for each instantiation of any class (even models).... then... no comment... |
Beta Was this translation helpful? Give feedback.
-
|
@henzeb this reminds me of: http://harmful.cat-v.org/software/c++/I_did_it_for_you_all |
Beta Was this translation helpful? Give feedback.
-
|
@marius-mcp Starting from 8.4 Deprecated as well https://www.php.net/manual/en/class.deprecated.php |
Beta Was this translation helpful? Give feedback.
-
Since the introduction of attributes I always stated that they should be used only when they are the only option.
Finally I found one case when they are the only option (that I know of).
https://www.php.net/manual/en/class.override.php
Do you know other situations when the attributes would be the only option?
(side note: this attribute does not need reflection from what I see, it is embedded in php).
@henzeb said also: ArrayShape
@dmitrychurkin said: Deprecated
Beta Was this translation helpful? Give feedback.
All reactions