Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] - post_max_size of 0 throws PostTooLargeException for POST requests of any size #17602

Closed
prurigro opened this issue Jan 27, 2017 · 2 comments

Comments

@prurigro
Copy link

  • Laravel Version: 5.4.5
  • PHP Version: 7.0.10
  • Database Driver & Version: N/A

Description:

Setting post_max_size to 0 should disable the post size limit, but getPostMaxSize in https://github.com/laravel/framework/blob/5.4/src/Illuminate/Foundation/Http/Middleware/ValidatePostSize.php treats it as a maximum post size of 0 bytes and throws the PostTooLargeException exception for POST requests of any size.

Steps To Reproduce:

Set post_max_size to 0 in php.ini and attempt to send a POST request to trigger this check (eg: log in using Laravel's native authentication)

@GrahamCampbell
Copy link
Member

Thanks for reporting. See #17607. :)

@prurigro
Copy link
Author

Awesome- thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants