[5.4] ConvertEmptyStringsToNull not working with 'sometimes' validation rule

[bkremenovic]

• Laravel Version: 5.4.x
• PHP Version: 7.0.13
• Database Driver & Version: N/A

Description:

There is a bug in a new Laravel's 5.4 middleware ConvertEmptyStringsToNull when using sometimes validation rule.

Steps To Reproduce:

$this->validate($request, [
    "firstname"     => "sometimes|max:50",
], [	
    "firstname.max" => "Ime ne smije sadržati više od :max karaktera !",
]);

Try removing \Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull::class, in Kernel.php. It works, then.

[tillkruss]

What happens if you add nullable to firstname?

[ankurk91]

The sometimes validation checks if that input present in $_POST array and if yes then it proceed with more validations.
sometimes won't make form field optional.
See issue #17663
Also check the note about optional field on Laravel Docs

[themsaid]

@ongulus what's in $request, there's no way we can help without knowing the input you use to test.

[srmklive]

@ongulus Can you specify the contents of the $request?

[themsaid]

Closing for lack of activity.

[bkremenovic]

The $request contains "firstname" POST field from

[bkremenovic]

Not a bug, but a feature :) According to Laravel's documentation - https://laravel.com/docs/5.4/validation#rule-nullable