Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.76.0] Redis flush array_unique error #40037

Closed
it-can opened this issue Dec 14, 2021 · 9 comments
Closed

[8.76.0] Redis flush array_unique error #40037

it-can opened this issue Dec 14, 2021 · 9 comments
Labels

Comments

@it-can
Copy link
Contributor

it-can commented Dec 14, 2021

  • Laravel Version: 8.76.0
  • PHP Version: 8.0.13
  • Database Driver & Version: MariaDB & Redis

Description:

Flushing redis generates this error:

array_unique(): Argument #1 ($array) must be of type array, null given

I think it has to do with #39939

Reverting back to 8.75.0 everything works again.

Steps To Reproduce:

Cache::tags('menu')->flush();
array_unique(): Argument #1 ($array) must be of type array, null given
@it-can it-can changed the title [8.x] Redis flush array_unique error [8.76.0] Redis flush array_unique error Dec 14, 2021
@dkuzmenchuk
Copy link
Contributor

Hi @it-can,

Could you please tell what redis client do you use, predis or phpredis?

@it-can
Copy link
Contributor Author

it-can commented Dec 14, 2021

phpredis

@DarkPain0
Copy link

We have the same issue after the last upgrade with phpredis

@taylorotwell
Copy link
Member

@dkuzmenchuk do you understand the problem and are you able to fix it? Otherwise, we need to revert this ASAP.

@dkuzmenchuk
Copy link
Contributor

@taylorotwell yes, I found a reason of this issue. Making new PR with a fix right now

@taylorotwell
Copy link
Member

@dkuzmenchuk do you have a time frame in mind for that?

@dkuzmenchuk
Copy link
Contributor

@taylorotwell I think there are more differences between Redis clients than just the return value. So I think we should revert my PR. In this case I'll have time to make more tests to be sure everything work good with my fixes in new PR

@taylorotwell
Copy link
Member

Reverted.

@dkuzmenchuk
Copy link
Contributor

I published new PR #40039 which contains changes from PR #39939, but takes into consideration that Laravel supports 2 Redis clients

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants