LazyCollection::every() type inferences by PHPStan are completely broken

[mpyw]

• Laravel Version: 9.3.1
• PHPStan Version: 1.4.5
• Larastan Version: 1.0.3
• PHP Version: 8.1

Description & Reproduction Steps:

$collection = new LazyCollection([new \stdClass]);
\PHPStan\dumpType($collection->every(...));

Expected:

Dumped type: Closure((callable(stdClass, int): bool)|stdClass|string, mixed, mixed): bool

Actual:

Dumped type: Closure((callable(int, int): bool)|int|string, mixed, mixed): bool

Though I haven't determined yet whether it is a PHPStan bug or a Laravel bug, I'll submit it as a Laravel issue for the time being.

[mpyw]

I also hope that #40889 should be resolved although it is not directly related. It is very inconvenient that Collection<Item> is NOT considered a subtype of Collection<ItemInterface> whereas Item[] is considered a subtype of ItemInterface[].

I'm currently trying to upgrade Laravel apps from 8.x to 9.x, but getting stuck with the PHPStan type inference problems of collection generics.

[mpyw]

Related

• [9.x] Improves Support\Collection and Database\Eloquent\Collection type definitions #38538 by @nunomaduro
• [9.x] Improve Support\LazyCollection type definitions #39506 by @sebdesign

[driesvints]

Please just attempt a PR if you want to adjust anything. No code is broken.

[mpyw]

@driesvints I confirmed that it's not reproducible in newly cloned laravel/laravel apps, however, it actually appears in my existing app. I'll research some more.

---

Screenshot:

[mpyw]

It's very odd, looks like LazyCollection::every() specific.

[mpyw]

wtf???

Method	Collection	LazyCollection
every()	✅	❌
some()	❌	❌
map() filter()	✅	✅

[mpyw]

A clean install solved the problem. I can't reproducd the bug anymore regardless I haven't touch directly inside vendor and prepare the same version of composer.lock as before. I have no idea what's going on. Was the cache corrupted?

[mpyw]

Reproduced again

[mpyw]

Confirmed that the TValue inferencing is unexpectedly replaced with TKey.

[mpyw]

Re-published as a PHPStan issue: phpstan/phpstan#6768