-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
\Illuminate\Database\Eloquent\Concerns\PreventsCircularRecursion use \Illuminate\Support\Onceable who has a laravel dependency #52828
Comments
Thank you for reporting this issue! As Laravel is an open source project, we rely on the community to help us diagnose and fix issues as it is not possible to research and fix every issue reported to us via GitHub. If possible, please make a pull request fixing the issue you have described, along with corresponding tests. All pull requests are promptly reviewed by the Laravel team. Thank you! |
Shouldn't you be able to just run |
Thanks for your reply. I didn't know it was a standalone package. However, what do you think about to update the requirement of illuminate/support to include it ? |
It is already suggested in |
Ah ok ! Sorry I didn't check that. What about this time to add it in illuminate/database ? Because it's this package who is using the once function |
I'm responsible for |
Marking this issue as close, the package is already suggested in support and will be suggested in databaae coming next release |
Laravel Version
11.22.0
PHP Version
8.3.0
Database Driver & Version
No response
Description
Hello,
On different projects, we are using eloquent as standalone package.
Everything was working well since the release v11.22.0.
In this release, a refactoring was done and introduce a new trait Eloquent/Concerns/PreventsCircularRecursion.php.
This trait is using the class Onceable from package Support
The class Onceable is using use
\Laravel\SerializableClosure\Support\ReflectionClosure
.As we don't have laravel as dependency, we cannot upgrade illuminate/database depdendency.
Do you think that there is a chance to solve this issue ?
Sorry if I didn't write at the right place to report this issue.
Thanks
Steps To Reproduce
You can take look on line 6 file of Onceable.php
The text was updated successfully, but these errors were encountered: