-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Swoole] Support large streamed response #636
Comments
I'm clueless, maybe this is not the buffering/memory issue. I noticed it fails at around 30 seconds, so I increased the Octane's and Swoole's execution limits. It does not reach the limit anymore, but the worker fails:
Note, I have no problem with streaming small data. And I modified the Octane's code to completely omit the code path with |
Are you using Laravel's stream responses? If so, please submit a pull request with the required modifications in Octane, including a failing test that would be resolved by your new code. I will be closing this issue, but don't worry! I will follow up and assist you with the pull request. ❤️ |
FYI, it looks like it was a memory leak in Swoole swoole/swoole-src#4974 |
I've seen #109 that discusses and fixes
StreamedResponse
support. However, this does not work for very large output (in gigabytes) because it's buffered inSwooleClient::endResponseContent()
.A solution would be to use something like in https://gist.github.com/27pchrisl/6dbe0993b2423531b4afaf406a05224d
Would any of this be acceptable for Octane 1.x?
Please, do not just close the ticket, I'm willing to work on this, but any help would be appreciated.
The text was updated successfully, but these errors were encountered: