Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master: HandlesOAuthErrors middleware unable to actually handle errors #1062

Closed
TimWolla opened this issue Aug 9, 2019 · 2 comments
Closed
Labels
Milestone

Comments

@TimWolla
Copy link
Contributor

TimWolla commented Aug 9, 2019

  • Passport Version: dev-master with commit 7959c6c
  • Laravel Version: 5.8.30
  • PHP Version: 7.3.4 (Debian Buster)
  • Database Driver & Version: MySQL 8.0.17

Description:

The new HandlesOAuthErrors middleware is unable to actually handle errors, because Laravel intercepts Exceptions of the final destination of the middleware pipeline:

https://github.com/laravel/framework/blob/9097786caae30e9ca243874e5c807609f1f2728e/src/Illuminate/Pipeline/Pipeline.php#L133

see also my comment in the PR introducing the middleware: #937 (comment)

Steps To Reproduce:

Attempt to use Passport within a Laravel application and open /oauth/authorize with an invalid client_id. You'll see an HTTP 500 instead of a proper JSON response explaining the issue.

@driesvints
Copy link
Member

The PR for this was merged into master.

@donmbelembe
Copy link

I'm still getting a generic error on passport 8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants