-
Notifications
You must be signed in to change notification settings - Fork 136
Commit
- Loading branch information
There are no files selected for viewing
3 comments
on commit 8331382
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you've previously installed both packages on travis, with or without package.json. Try to remove node_modules directory on travis-ci again and see what happens. Or try to clone this repo, do npm i
and also see what happens when starting e2e tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey,
Travis is a clean install each time, it's a docker container.
Also I cannot replicate locally (or on appveyor). That is the point of CI.
It makes sense that we should have serve-static
installed - I'm thinking it is coming through as a dependency of another module depending on the node version - just wondering why we're not seeing it anywhere here.
Is it just serve-static
that you're missing?
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. Thank you for your reply. Its also the connect
which was not found.
If doing only e2e/protractor, none of the dependencies have a sub-dependency to serve-static
and connect
.
My package.json currently includes both:
"connect": "^3.6.2",
"serve-static": "^1.12.3",
@lathonez you may want to add these to the
package.json
file