Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tester crate version to 0.5.0 #144

Merged
merged 2 commits into from
Oct 29, 2018
Merged

Bump tester crate version to 0.5.0 #144

merged 2 commits into from
Oct 29, 2018

Conversation

messense
Copy link
Contributor

No description provided.

Copy link
Contributor

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in 0.4.2 were a breaking change. messense/rustc-test@aeb054e changes the type of tester::TestOpts in a breaking way such that compiletest-rs currently fails to compile. I believe tester 0.4.2 should be yanked and published as 0.5.0 instead.

@messense messense changed the title Bump minimum version for tester crate Bump tester crate version to 0.5.0 Oct 29, 2018
@messense
Copy link
Contributor Author

Yanked 0.4.2 and bumped version to 0.5.0.

@laumann
Copy link
Collaborator

laumann commented Oct 29, 2018

Thanks @messense, I'd like to have #142 merged before merging this, is that OK?

@messense
Copy link
Contributor Author

Sure.

@laumann
Copy link
Collaborator

laumann commented Oct 29, 2018

@messense OK, #142 is merged, could you rebase this on master?

@messense
Copy link
Contributor Author

Travis passed.

@laumann
Copy link
Collaborator

laumann commented Oct 29, 2018

Excellent!

@laumann laumann merged commit bc26d56 into Manishearth:master Oct 29, 2018
@messense messense deleted the tester-run_ignored branch October 29, 2018 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants